1953977 - SyncedBookmarksMirror.fetchLocalChangeRecords doesn't always abort a connection properly when signalled

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P3)

Description

[Mark Banner (:standard8)]

When looking at fixing TypeScript issues on SyncedBookmarksMirror.sys.mjs, I noticed that there is a case where we check signal.interrupted, where signal is of type AbortSignal, but it does not have a interrupted property. Given the rest of the code in the file it looks like it should be aborted.

If I understand the code correctly, then the adverse effect could be that if we happened to abort at the time of that query, then we would not abort the query straight away, but carry on until the query had finished. I think realistically, there's unlikely to be a lot of records, so this probably isn't a significant issue, though we should fix it anyway.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1953977 - Fix issue in aborting the fetch of local change records for bookmark sync. r?#places-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a49195e4b8b
Fix issue in aborting the fetch of local change records for bookmark sync. r=places-reviewers,daisuke

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1a49195e4b8b