Closed Bug 1954155 Opened 1 year ago Closed 1 year ago

Tools resizing and overflow in vertical tabs

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
141 Branch
Tracking Status
firefox141 --- fixed

People

(Reporter: asafko, Assigned: kcochrane)

References

(Regressed 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

User story
As a vertical tabs user, I can control how many tools I want to keep at my fingertips in the sidebar.

Figma

Acceptance criteria

  1. Once the number of tools in the sidebar reaches three (3), I see a divider control that allows me to adjust the number tools visible in the launcher by collapsing some of them into the overflow menu.
  2. Dragging the divider down collapse tools icons into the overflow menu. The collapsing starts from the “bottom” of the tools, with the lowest item collapsing first.
  3. I can collapse all of my tools into the overflow menu, leaving only the overflow icon visible.
  4. Tools collapsed into the overflow menu are available by clicking on the overflow icon.
  5. Tools do not overflow in the expanded sidebar. Instead, once the max number of items per row is reached, the remaining icons are placed into the second row, underneath the first one.
Whiteboard: [fidefe-sidebar]
Summary: Tools overflow in the collapsed vertical tabs → Tools resizing and overflow in vertical tabs
Duplicate of this bug: 1954158

A note of clarification, this won't apply to expand on hover since users won't be able to resize tools with a divider - its only for vertical tabs with always-show setting. Also I discussed with Ania and Yulia that we want to remove the label for tools in the expanded state (for all modes where we still have this).

Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Attachment #9488765 - Attachment description: WIP: Bug 1954155 - Add resize and overflow functionality to tools area of the sidebar → Bug 1954155 - Add resize and overflow functionality to tools area of the sidebar
Blocks: 1971859
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/23345d0b8082 https://hg.mozilla.org/integration/autoland/rev/5abd2e3ad94a Add resize and overflow functionality to tools area of the sidebar r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,fluent-reviewers,bolsson,nsharpley,sfoster
Regressions: 1971922
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
Duplicate of this bug: 1971666
Regressions: 1972148
Duplicate of this bug: 1963639
Duplicate of this bug: 1972484
Duplicate of this bug: 1972237
Blocks: 1972629
Duplicate of this bug: 1973213
QA Whiteboard: [qa-triage-done-c142/b141]

Should that be added to our 141 beta and final release notes? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination#Nomination_in_Bugzilla

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane) → needinfo?(asafko)

:pascalc, looks like Ania already added release notes for this here.

Flags: needinfo?(asafko) → needinfo?(pascalc)
Flags: needinfo?(pascalc)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: