195440 - crash when I cancel during downloading list of newsgroups

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[(not reading, please use [e-mail] instead)]

create new profile, create news account. Enter "news" as news server id and 
then select "Subscribe to newsgroups". As we are downloading the newsgoups 
(watch display at bottom of window) click the "cancel" button, watch it crash.

the problem is m_request is null.  patch coming...

Source File Name 
	c:/builds/seamonkey/mozilla/mailnews/news/src/nsNNTPProtocol.cpp
Trigger Line No. 	3371
Stack Trace 	
nsNNTPProtocol::TimerCallback 
[c:/builds/seamonkey/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 3371]
nsNNTPProtocol::Notify 
[c:/builds/seamonkey/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 3346]
nsTimerImpl::Fire [c:/builds/seamonkey/mozilla/xpcom/threads/nsTimerImpl.cpp, 
line 395]
nsAppShell::Run [c:/builds/seamonkey/mozilla/widget/src/windows/nsAppShell.cpp, 
line 176]
nsAppShellService::Run 
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 480]
main1 [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1289]
main [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1639]
WinMain [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1660]
WinMainCRTStartup()
kernel32.dll + 0x214c7 (0x77e814c7)

Comment 1

[(not reading, please use [e-mail] instead)]

this is a regression from the async i/o landing, I think, so we want it on 1.3 
final.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 3

[Darin Fisher]

Comment on attachment 115901 [details] [diff] [review]
patch

r/sr=darin

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

don't assert.  this is legit, if CloseSocket() is called, which will null out
m_request.

thanks to darin for the r/sr.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 115903 [details] [diff] [review]
updated patch

this has r/sr darin

Comment 6

[(not reading, please use [e-mail] instead)]

fixed on the trunk.  I'll ping drivers for 1.3 final.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 115903 [details] [diff] [review]
updated patch

a=asa (on behalf of drivers) for checkin to 1.3

Comment 8

[(not reading, please use [e-mail] instead)]

fixed on trunk and 1.3 final branch.

Comment 9

[Ninoschka Baca]

Trunk build 2003-05-22: WinMe, Mac 10.1.5
Verified Fixed. I no longer crashes after canceling the download of newsgroups
(i.e. news)