1954418 - Remove ISimpleDOM code that only works for LocalAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Content from the web itself has been rendered in a content process for a long time now. Cache the World shipped 2 years ago and the old implementation based on cross-process COM was removed. Practically, this means the only usable ISimpleDOM functionality is the code specific to RemoteAccessible, since the LocalAccessible code is only usable in Firefox's own UI. Thus, we should remove any ISimpleDOM functionality specific to LocalAccessible, which means most of it.

There is an ongoing effort between us, Chromium and AT vendors to remove ISimpleDOM altogether, but we're not quite there yet, so we can't just completely remove it.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1954418 part 1: Remove ISimpleDOM code that only works for LocalAccessible.

We have a lot of ISimpleDOM code which only works for LocalAccessible.
Because all web content uses RemoteAccessible now, practically, the only usable ISimpleDOM functionality is that which works for RemoteAccessible.
Therefore, remove all code that only works for LocalAccessible.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1954418 part 2: Remove the ability to construct an sdnAccessible with a DOM node.

Previously, the LocalAccessible implementation of ISimpleDOM allowed clients to walk to DOM nodes which were not included in the accessibility tree.
Thus, it was necessary for sdnAccessible to be constructed with either an Accessible or a DOM node.
Now that this functionality has been removed, we no longer need to support construction with a DOM node.
This allows other code such as QueryInterface to be simplified as well, since an sdnAccessible now always has a corresponding MsaaAccessible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8021b6e2b08
part 1: Remove ISimpleDOM code that only works for LocalAccessible. r=morgan
https://hg.mozilla.org/integration/autoland/rev/51b993ed6ee9
part 2: Remove the ability to construct an sdnAccessible with a DOM node. r=morgan

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a8021b6e2b08
https://hg.mozilla.org/mozilla-central/rev/51b993ed6ee9