1954422 - gbm/gbm.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Dan Horák]

Seems https://phabricator.services.mozilla.com/D240988 breaks build on ppc64le and s390x. Isn't it just an include dir missing from CPPFLAGS/CFLAGS?

...
accessible/atk/DocAccessibleWrap.o
/usr/bin/g++ -o DocAccessibleWrap.o -c  -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/stl_wrappers -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/system_wrappers -include /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstrict-flex-arrays=1 -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/accessible/atk -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/base -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/generic -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/html -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/ipc -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/xpcom -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/xul -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/layout/generic -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/other-licenses/atk-1.0 -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/widget -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/widget/gtk -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/ipc/ipdl/_ipdlheaders -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/ipc/chromium/src -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/nspr -I/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/nss -DMOZILLA_CLIENT -include /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/mozilla-config.h -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -fno-math-errno -fno-exceptions -pipe -fPIC -g0 -gdwarf-4 -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wcomma-subscript -Wvolatile -Wno-deprecated-enum-enum-conversion -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cloudproviders -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/fribidi -I/usr/include/libxml2 -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/webp -DWITH_GZFILEOP -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -pthread -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -Wno-error=unused-function -Wno-unused-local-typedefs -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/DocAccessibleWrap.o.pp   /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk/DocAccessibleWrap.cpp
In file included from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/AlreadyAddRefed.h:14,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/nsCOMPtr.h:25,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk/AccessibleWrap.h:10,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/generic/HyperTextAccessible.h:9,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/generic/DocAccessible.h:9,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk/DocAccessibleWrap.h:14,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk/DocAccessibleWrap.cpp:7:
/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/Assertions.h:287:8: warning: #warning "Unsupported architecture, replace the code below with assembly suitable to crash the process" [-Wcpp]
  287 | #      warning \
      |        ^~~~~~~
In file included from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/widget/nsWaylandDisplay.h:11,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/widget/WaylandSurface.h:11,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/widget/MozContainerWayland.h:16,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/widget/gtk/MozContainer.h:12,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/widget/gtk/nsWindow.h:15,
                 from /home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/accessible/atk/DocAccessibleWrap.cpp:11:
/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/dist/include/mozilla/widget/DMABufLibWrapper.h:11:10: fatal error: gbm/gbm.h: No such file or directory
   11 | #include "gbm/gbm.h"
      |          ^~~~~~~~~~~
compilation terminated.
gmake[4]: *** [/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/config/rules.mk:676: DocAccessibleWrap.o] Error 1
gmake[4]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/obj-s390x-ibm-linux-gnu/accessible/atk'
gmake[3]: *** [/home/jenkins/workspace/Firefox-default/label/s390x-big/firefox/config/recurse.mk:72: accessible/atk/target-objects] Error 2
...

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1941671

:stransky, since you are the author of the regressor, bug 1941671, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I think gbm is exported for pipewire and we see this failure if pipewire is disabled.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1954422 [Linux] Always exports gbm/gbm.h r?emilio

Comment 4

[Petr Sumbera]

I see this on Solaris too. But the prosposed fix doesn't seem to resolve the issue. On Solaris I see just: /usr/include/gbm.h

Comment 5

[Martin Stránský [:stransky] (ni? me)]

We may also need to build third_party dir on Linux: https://searchfox.org/mozilla-central/source/dom/media/webrtc/moz.build#91 to actually do the file export.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bdd68534f63
[Linux] Always exports gbm/gbm.h r=emilio

Comment 7

[Petr Sumbera]

Thank you for fixing this!

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6bdd68534f63

Comment 9

[Dan Horák]

for the record, all looks good on ppc64le and s390x now