1954474 - [Dev Tools] Error: Protocol error (NS_ERROR_XPC_BAD_CONVERT_NATIVE); when opening the dev tools at https://openguessr.com/

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[ferrytinymailbox]

Error:
Error: Protocol error (NS_ERROR_XPC_BAD_CONVERT_NATIVE): Component returned failure code: 0x8057000a (NS_ERROR_XPC_BAD_CONVERT_NATIVE) [nsIJSEnumerator.next] from: server0.conn4.watcher3 (resource://devtools/server/connectors/js-process-actor/target-watchers/window-global.sys.mjs:160:0)

Server Stack: createTargetsForWatcher@resource://devtools/server/connectors/js-process-actor/target-watchers/window-global.sys.mjs:160:3
#watchNewTargetTypeForWatcher@resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs:203:40
receiveMessage@resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs:306:50

Stacktrace:
onPacket/<@resource://devtools/shared/protocol/Front.js:382:31
DevTools RDP*request@resource://devtools/shared/protocol/Front.js:299:14
generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
startListening@resource://devtools/shared/commands/target/target-command.js:533:35
open@resource://devtools/client/framework/toolbox.js:975:41

This does not happen on a new profile with the same extensions, but it does happen in a private tab

Comment 1

[Julian Descottes [:jdescottes] (PTO 20 oct -> 25 oct)]

Thanks for the report!

Can you share your about:support information? It will contain the list of addons you are using, which might be relevant here.
Also can you describe in more details how many windows / private windows you had when trying to open devtools? Was https://openguessr.com/ opened in the private window?

Also which operating system are you using, and which Firefox version?

Thanks!

Comment 2

[ferrytinymailbox]

Attachment: Firefox support data.json

Comment 3

[ferrytinymailbox]

Note that restarting Firefox made it no longer reproduceable.

Also can you describe in more details how many windows / private windows you had when trying to open devtools?

I think I had around 30-40 tabs in 1 window open. At the start I had 0 private windows open, I opened one to test if the issue also happened in that tab.

Was https://openguessr.com/ opened in the private window?

Opening the dev tools on this website caused the crash for me. Later during the day I also got the crash with any other other website. The website in question seems like a red herring to me that I discovered more information about it

More proof that the website is a red herring is that at my work place, one co-worker (on Ubuntu, Firefox via Snap) opened the dev tools at a standard NGINX error page (a 502 in this case, which did not refer to any other external links) and also got the browser dev tools bug at every other tab, they also fixed the issue by restarting Firefox

Also which operating system are you using, and which Firefox version?

Running 136.0.1 (64-bits) on Arch Linux

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

We're getting other reports about this, we should look into it
The error is triggered by Services.ww.getWindowEnumerator in https://searchfox.org/mozilla-release/rev/62f34235d373482fc8c3c6a07f3a60c3e224d642/devtools/server/connectors/js-process-actor/target-watchers/window-global.sys.mjs#160-162

for (const window of Services.ww.getWindowEnumerator()) {
  topWindows.push(window);
}

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

We couldn't reproduce this issue so far. Might be something related to extensions creating weird windows.
Ultimately Services.ww.getWindowEnumerator() shouldn't throw like that, so it should be fixed at the platform level.
Alex will check if this error would indeed crash the toolbox without the AppErrorBoundary

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1954474 - [devtools] Avoid crashing DevTools when processing some buggy top level documents.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e00ffc1402a
[devtools] Avoid crashing DevTools when processing some buggy top level documents. r=devtools-reviewers,jdescottes

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e00ffc1402a

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Alex, should we request an uplift to 138? We're getting multiple reports of this issue

Comment 13

[Alexandre Poirot [:ochameau]]

Comment on attachment 9475052 [details]
Bug 1954474 - [devtools] Avoid crashing DevTools when processing some buggy top level documents.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: DevTools may crash on opening.
  Unfortunately, the STR is unknown. It may involve some particular add-on or preference.
  But we got 3 reports about this particular exception in a short period of time.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is quite simple.
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9475052 [details]
Bug 1954474 - [devtools] Avoid crashing DevTools when processing some buggy top level documents.

Approved for 138.0b6

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1dab9e6afb8