1954488 - Tab groups are deleted from the list all tabs menu if a session without the previous tab groups inside the tab strip is restored

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2025-03-17_15h34_13.mp4

Found in

• Nightly 138.0a1 (2025-03-17)

Affected versions

• Nightly 138.0a1 (2025-03-17)
  Beta 137.0b6

Affected platforms

• All

Steps to reproduce

1. Have 5 tab groups saved in the Tabstrip.
2. Close and Reopen the browser.
3. Open the List all tabs menu.
4. Open any website as a free tab without opening any Tab groups.
5. Close and Reopen the browser.
6. Reopen the List All tabs menu.
7. Restore the previous session from History.

Expected result

• The Previous session should be restored while the Tab groups should still be saved in the Tab groups session.

Actual result

• The Tab groups are deleted from the List all tabs menu after the previous session with no tab groups is restored.
  Please note that before restoring the previous session all tab groups are still saved in the list all tabs menu, but after we restore the session with just one free tab, some of the tab groups seem to disappear if not all of them.

Regression range
Not a Regression

Comment 1

[DJ (:dwalker)]

appears to be caused by the removeAfterRestore behavior implemented in bug 1951319

Comment 2

[Jeremy Swinarton]

Attachment: Bug 1954488: Delete removeAfterRestore property from savedGroups if the session is being quit for the second time r?dao,dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efd5ce2aaacf
Delete removeAfterRestore property from savedGroups if the session is being quit for the second time r=dwalker,sthompson,sessionstore-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/efd5ce2aaacf

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 138.0a1 (2025-03-19) ID 20250319040934

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jswinarton, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Jeremy Swinarton]

Attachment: Bug 1954488: Delete removeAfterRestore property from savedGroups if the session is being quit for the second time r?dao,dwalker,sthompson

Original Revision: https://phabricator.services.mozilla.com/D241978

Comment 8

[Jeremy Swinarton]

Attachment: Bug 1954488: Delete removeAfterRestore property from savedGroups if the session is being quit for the second time r?dao,dwalker,sthompson

Original Revision: https://phabricator.services.mozilla.com/D241978

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: In certain situations where a user restarts the browser more than once, data loss of saved groups is possible.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=1954488#c0
• Risk associated with taking this patch: Low
• Explanation of risk level: Could potentially affect behaviour implemented in bug1951319, but since this is a one-line change it is not likely. Also the code paths are well tested.
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/81db79c85b31

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 137.0b9 ID 20250320125448