1954534 - java.lang.SecurityException: Isolated process not allowed to call getContentProvider with enable-isolated-process

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Makoto Kato [:m_kato]]

When selecting word with isolated-process, SecurityException is thrown on content process.

03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 112 ("Gecko")
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: java.lang.SecurityException: Isolated process not allowed to call getContentProvider
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.os.Parcel.readException(Parcel.java:1683)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.os.Parcel.readException(Parcel.java:1636)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.app.ActivityManagerProxy.getContentProvider(ActivityManagerNative.java:4169)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.app.ActivityThread.acquireProvider(ActivityThread.java:5434)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.app.ContextImpl$ApplicationContentResolver.acquireProvider(ContextImpl.java:2248)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.content.ContentResolver.acquireProvider(ContentResolver.java:1499)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.provider.Settings$NameValueCache.lazyGetProvider(Settings.java:1554)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.provider.Settings$NameValueCache.getStringForUser(Settings.java:1597)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.provider.Settings$System.getStringForUser(Settings.java:1911)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.provider.Settings$System.getIntForUser(Settings.java:1981)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at android.provider.Settings$System.getInt(Settings.java:1976)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at org.mozilla.gecko.GeckoAppShell.vibrateOnHapticFeedbackEnabled(GeckoAppShell.java:985)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at org.mozilla.gecko.GeckoAppShell.performHapticFeedback(GeckoAppShell.java:964)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
03-18 01:31:20.573  2830  2844 E GeckoCrashHandler: 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:498)

Also, when I look bug 1946043's failures, it seems to be same exception.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1954534 - Part 1. Move haptic feedback implementation to hal. r=gsvelto!

Actually, nsIHapticFeedback is called on content process. Then it calls
OS APIs on content process. So if is is isolated process, it doesn't
work or it will crash.

This patch moves haptic feedback implementation to hal to call OS APIs
on chrome process, like vibration.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1954534 - Part 2. Unified nsHapticFeedback. r=gsvelto!

Since nsIHapticFeedback's logic is moved to hal, we can unify
nsHapticFeedback.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a0f4cf98b5
Part 1. Move haptic feedback implementation to hal. r=geckoview-reviewers,gsvelto,ohall
https://hg.mozilla.org/integration/autoland/rev/625e60d4c76b
Part 2. Unified nsHapticFeedback. r=gsvelto

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/91a0f4cf98b5
https://hg.mozilla.org/mozilla-central/rev/625e60d4c76b