1954581 - saveHelper fails completely if network request does not hit onStartRequest (sends headers) within the timeout

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[:Gijs (he/him)]

STR:

1. Set browser.download.saveLinkAsFilenameTimeout to something small, like 300
2. Go to any page with a video, e.g. https://bugs.kde.org/attachment.cgi?id=175313 .
3. right click and click "save video as"

ER:
file save dialog

AR:
error in browser console:

TypeError: can't access property "saveURL", this.window is undefined
saveLinkAs_onStopRequest chrome://browser/content/nsContextMenu.sys.mjs:2027

Comment 1

[:Gijs (he/him)]

I found this through the report in bug 1952672 which reported slowness. Obviously it sometimes not working at all is not helping with this, though equally I think probably there is more going on that we could do to make the UI more responsive.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1895563

:niklas, since you are the author of the regressor, bug 1895563, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1954581 - fix media/link saving helper breaking if we do not get headers (onStartRequest) within the 4s timeout, r?niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aef8cee98899
fix media/link saving helper breaking if we do not get headers (onStartRequest) within the 4s timeout, r=niklas

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/aef8cee98899

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1954581 - fix media/link saving helper breaking if we do not get headers (onStartRequest) within the 4s timeout, r?niklas

Original Revision: https://phabricator.services.mozilla.com/D241894

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Broken link/video/audio/image saving in some cases
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0
• Risk associated with taking this patch: Low
• Explanation of risk level: 1-character typo fix, with automated test
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/697917390d08

Comment 9

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce the issue on an affected Nightly build from 2025-03-17 on Windows 11.
After verifying the fix on the latest Nightly 138.0a1 (20250319204742) and Beta 137.0b8 (20250319094417), I can confirm that the issue has been resolved on Windows 11, MacOS 11 and Ubuntu 22.

The "Save Video As" functionality now works correctly, even when the network request does not trigger onStartRequest within the timeout. No errors were observed, and the file save dialog appears as expected when attempting to save the video.

I am closing this as VERIFIED FIXED.