1954653 - Newtab ads and content reporting UI

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Comment 1

[Reem Hamoui]

Attachment: Bug 1954653 - Build reporting UI. r=#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff8b03537040
Build reporting UI. r=home-newtab-reviewers,fluent-reviewers,frontend-codestyle-reviewers,mossop,nbarrett,bolsson

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing node newtab failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/09f348af745eab241ff2ffd07a34d9f000855dd9

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | bundles | activity-stream.html out of date

TEST-START | bundles
[task 2025-03-26T03:29:12.130Z] TEST-UNEXPECTED-FAIL | bundles | activity-stream.html out of date
[task 2025-03-26T03:29:12.130Z] TEST-UNEXPECTED-FAIL | bundles | activity-stream-debug.html out of date
[task 2025-03-26T03:29:12.130Z] TEST-UNEXPECTED-FAIL | bundles | activity-stream-noscripts.html out of date
[task 2025-03-26T03:29:12.130Z] TEST-START | karma /builds/worker/checkouts/gecko/browser/extensions/newtab
[task 2025-03-26T03:29:25.061Z] webpack was not included as a framework in karma configuration, setting this automatically...
[task 2025-03-26T03:29:25.066Z] TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | activity-stream:ActionTypes should be in alpha order: expected 'ABOUT_SPONSORED_TOP_SITES, ADDONS_INFO_REQUEST, ADDONS_INFO_RESPONSE, ADS_FEED_UPDATE, ADS_INIT, ADS_UPDATE_DATA, ARCHIVE_FROM_POCKET, BLOCK_SECTION, BLOCK_URL, BOOKMARK_URL, CARD_SECTION_IMPRESSION, CLEAR_PREF, COPY_DOWNLOAD_LINK, DELETE_BOOKMARK_BY_ID, DELETE_FROM_POCKET, DELETE_HISTORY_URL, DIALOG_CANCEL, DIALOG_CLOSE, DIALOG_OPEN, DISABLE_SEARCH, DISCOVERY_STREAM_COLLECTION_DISMISSIBLE_TOGGLE, DISCOVERY_STREAM_CONFIG_CHANGE, DISCOVERY_STREAM_CONFIG_RESET, DISCOVERY_STREAM_CONFIG_RESET_DEFAULTS, DISCOVERY_STREAM_CONFIG_SETUP, DISCOVERY_STREAM_CONFIG_SET_VALUE, DISCOVERY_STREAM_DEV_BLOCKS, DISCOVERY_STREAM_DEV_BLOCKS_RESET, DISCOVERY_STREAM_DEV_EXPIRE_CACHE, DISCOVERY_STREAM_DEV_IDLE_DAILY, DISCOVERY_STREAM_DEV_IMPRESSIONS, DISCOVERY_STREAM_DEV_SHOW_PLACEHOLDER, DISCOVERY_STREAM_DEV_SYNC_RS, DISCOVERY_STREAM_DEV_SYSTEM_TICK, DISCOVERY_STREAM_EXPERIMENT_DATA, DISCOVERY_STREAM_FEEDS_UPDATE, DISCOVERY_STREAM_FEED_UPDATE, DISCOVERY_STREAM_IMPRESSION_STATS, DISCOVERY_STREAM_LAYOUT_RESET, DISCOVERY_STREAM_LAYOUT_UPDATE, DISCOVERY_STREAM_LINK_BLOCKED, DISCOVERY_STREAM_LOADED_CONTENT, DISCOVERY_STREAM_PERSONALIZATION_INIT, DISCOVERY_STREAM_PERSONALIZATION_LAST_UPDATED, DISCOVERY_STREAM_PERSONALIZATION_OVERRIDE, DISCOVERY_STREAM_PERSONALIZATION_RESET, DISCOVERY_STREAM_PERSONALIZATION_TOGGLE, DISCOVERY_STREAM_PERSONALIZATION_UPDATED, DISCOVERY_STREAM_POCKET_STATE_INIT, DISCOVERY_STREAM_POCKET_STATE_SET, DISCOVERY_STREAM_PREFS_SETUP, DISCOVERY_STREAM_RECENT_SAVES, DISCOVERY_STREAM_RETRY_FEED, DISCOVERY_STREAM_SPOCS_CAPS, DISCOVERY_STREAM_SPOCS_ENDPOINT, DISCOVERY_STREAM_SPOCS_PLACEMENTS, DISCOVERY_STREAM_SPOCS_UPDATE, DISCOVERY_STREAM_SPOC_BLOCKED, DISCOVERY_STREAM_SPOC_IMPRESSION, DISCOVERY_STREAM_TOPICS_LOADING, DISCOVERY_STREAM_USER_EVENT, DOWNLOAD_CHANGED, FAKESPOT_CTA_CLICK, FAKESPOT_DISMISS, FAKE_FOCUS_SEARCH, FILL_SEARCH_TERM, FOLLOW_SECTION, HANDOFF_SEARCH_TO_AWESOMEBAR, HIDE_PERSONALIZE, HIDE_PRIVACY_INFO, HIDE_TOAST_MESSAGE, INIT, INLINE_SELECTION_CLICK, INLINE_SELECTION_IMPRESSION, MESSAGE_CLICK, MESSAGE_DISMISS, MESSAGE_IMPRESSION, MESSAGE_SET, MESSAGE_TOGGLE_VISIBILITY, NEW_TAB_INIT, NEW_TAB_INITIAL_STATE, NEW_TAB_LOAD, NEW_TAB_REHYDRATED, NEW_TAB_STATE_REQUEST, NEW_TAB_UNLOAD, OPEN_ABOUT_FAKESPOT, OPEN_DOWNLOAD_FILE, OPEN_LINK, OPEN_NEW_WINDOW, OPEN_PRIVATE_WINDOW, OPEN_WEBEXT_SETTINGS, PARTNER_LINK_ATTRIBUTION, PLACES_BOOKMARKS_REMOVED, PLACES_BOOKMARK_ADDED, PLACES_HISTORY_CLEARED, PLACES_LINKS_CHANGED, PLACES_LINKS_DELETED, PLACES_LINK_BLOCKED, PLACES_SAVED_TO_POCKET, POCKET_CTA, POCKET_LINK_DELETED_OR_ARCHIVED, POCKET_LOGGED_IN, POCKET_THUMBS_DOWN, POCKET_THUMBS_UP, POCKET_WAITING_FOR_SPOC, PREFS_INITIAL_VALUES, PREF_CHANGED, PREVIEW_REQUEST, PREVIEW_REQUEST_CANCEL, PREVIEW_RESPONSE, REMOVE_DOWNLOAD_FILE, REPORT_OPEN, REPORT_CLOSE, RICH_ICON_MISSING, SAVE_SESSION_PERF_DATA, SAVE_TO_POCKET, SCREENSHOT_UPDATED, SECTION_DEREGISTER, SECTION_DISABLE, SECTION_ENABLE, SECTION_OPTIONS_CHANGED, SECTION_REGISTER, SECTION_UPDATE, SECTION_UPDATE_CARD, SETTINGS_CLOSE, SETTINGS_OPEN, SET_PREF, SHOW_DOWNLOAD_FILE, SHOW_FIREFOX_ACCOUNTS, SHOW_PERSONALIZE, SHOW_PRIVACY_INFO, SHOW_SEARCH, SHOW_TOAST_MESSAGE, SKIPPED_SIGNIN, SOV_UPDATED, SUBMIT_EMAIL, SUBMIT_SIGNIN, SYSTEM_TICK, TELEMETRY_IMPRESSION_STATS, TELEMETRY_USER_EVENT, TOPIC_SELECTION_IMPRESSION, TOPIC_SELECTION_MAYBE_LATER, TOPIC_SELECTION_SPOTLIGHT_CLOSE, TOPIC_SELECTION_SPOTLIGHT_OPEN, TOPIC_SELECTION_USER_DISMISS, TOPIC_SELECTION_USER_OPEN, TOPIC_SELECTION_USER_SAVE, TOP_SITES_CANCEL_EDIT, TOP_SITES_CLOSE_SEARCH_SHORTCUTS_MODAL, TOP_SITES_EDIT, TOP_SITES_INSERT, TOP_SITES_OPEN_SEARCH_SHORTCUTS_MODAL, TOP_SITES_ORGANIC_IMPRESSION_STATS, TOP_SITES_PIN, TOP_SITES_PREFS_UPDATED, TOP_SITES_SPONSORED_IMPRESSION_STATS, TOP_SITES_UNPIN, TOP_SITES_UPDATED, TOTAL_BOOKMARKS_REQUEST, TOTAL_BOOKMARKS_RESPONSE, UNBLOCK_SECTION, UNFOLLOW_SECTION, UNINIT, UPDATE_PINNED_SEARCH_SHORTCUTS, UPDATE_SEARCH_SHORTCUTS, WALLPAPERS_CATEGORY_SET, WALLPAPERS_CUSTOM_SET, WALLPAPERS_FEATURE_HIGHLIGHT_COUNTER_INCREMENT, WALLPAPERS_FEATURE_HIGHLIGHT_CTA_CLICKED, WALLPAPERS_FEATURE_HIGHLIGHT_DISMISSED, WALLPAPERS_FEATURE_HIGHLIGHT_SEEN, WALLPAPERS_SET, WALLPAPER_CATEGORY_CLICK, WALLPAPER_CLICK, WALLPAPER_REMOVE_UPLOAD, WALLPAPER_UPLOAD, WEATHER_IMPRESSION, WEATHER_LOAD_ERROR, WEATHER_LOCATION_DATA_UPDATE, WEATHER_LOCATION_SEARCH_UPDATE, WEATHER_LOCATION_SUGGESTIONS_UPDATE, WEATHER_OPEN_PROVIDER_URL, WEATHER_QUERY_UPDATE, WEATHER_SEARCH_ACTIVE, WEATHER_UPDATE, WEBEXT_CLICK, WEBEXT_DISMISS' to equal 'ABOUT_SPONSORED_TOP_SITES, ADDONS_INFO_REQUEST, ADDONS_INFO_RESPONSE, ADS_FEED_UPDATE, ADS_INIT, ADS_UPDATE_DATA, ARCHIVE_FROM_POCKET, BLOCK_SECTION, BLOCK_URL, BOOKMARK_URL, CARD_SECTION_IMPRESSION, CLEAR_PREF, COPY_DOWNLOAD_LINK, DELETE_BOOKMARK_BY_ID, DELETE_FROM_POCKET, DELETE_HISTORY_URL, DIALOG_CANCEL, DIALOG_CLOSE, DIALOG_OPEN, DISABLE_SEARCH, DISCOVERY_STREAM_COLLECTION_DISMISSIBLE_TOGGLE, DISCOVERY_STREAM_CONFIG_CHANGE, DISCOVERY_STREAM_CONFIG_RESET, DISCOVERY_STREAM_CONFIG_RESET_DEFAULTS, DISCOVERY_STREAM_CONFIG_SETUP, DISCOVERY_STREAM_CONFIG_SET_VALUE, DISCOVERY_STREAM_DEV_BLOCKS, DISCOVERY_STREAM_DEV_BLOCKS_RESET, DISCOVERY_STREAM_DEV_EXPIRE_CACHE, DISCOVERY_STREAM_DEV_IDLE_DAILY, DISCOVERY_STREAM_DEV_IMPRESSIONS, DISCOVERY_STREAM_DEV_SHOW_PLACEHOLDER, DISCOVERY_STREAM_DEV_SYNC_RS, DISCOVERY_STREAM_DEV_SYSTEM_TICK, DISCOVERY_STREAM_EXPERIMENT_DATA, DISCOVERY_STREAM_FEEDS_UPDATE, DISCOVERY_STREAM_FEED_UPDATE, DISCOVERY_STREAM_IMPRESSION_STATS, DISCOVERY_STREAM_LAYOUT_RESET, DISCOVERY_STREAM_LAYOUT_UPDATE, DISCOVERY_STREAM_LINK_BLOCKED, DISCOVERY_STREAM_LOADED_CONTENT, DISCOVERY_STREAM_PERSONALIZATION_INIT, DISCOVERY_STREAM_PERSONALIZATION_LAST_UPDATED, DISCOVERY_STREAM_PERSONALIZATION_OVERRIDE, DISCOVERY_STREAM_PERSONALIZATION_RESET, DISCOVERY_STREAM_PERSONALIZATION_TOGGLE, DISCOVERY_STREAM_PERSONALIZATION_UPDATED, DISCOVERY_STREAM_POCKET_STATE_INIT, DISCOVERY_STREAM_POCKET_STATE_SET, DISCOVERY_STREAM_PREFS_SETUP, DISCOVERY_STREAM_RECENT_SAVES, DISCOVERY_STREAM_RETRY_FEED, DISCOVERY_STREAM_SPOCS_CAPS, DISCOVERY_STREAM_SPOCS_ENDPOINT, DISCOVERY_STREAM_SPOCS_PLACEMENTS, DISCOVERY_STREAM_SPOCS_UPDATE, DISCOVERY_STREAM_SPOC_BLOCKED, DISCOVERY_STREAM_SPOC_IMPRESSION, DISCOVERY_STREAM_TOPICS_LOADING, DISCOVERY_STREAM_USER_EVENT, DOWNLOAD_CHANGED, FAKESPOT_CTA_CLICK, FAKESPOT_DISMISS, FAKE_FOCUS_SEARCH, FILL_SEARCH_TERM, FOLLOW_SECTION, HANDOFF_SEARCH_TO_AWESOMEBAR, HIDE_PERSONALIZE, HIDE_PRIVACY_INFO, HIDE_TOAST_MESSAGE, INIT, INLINE_SELECTION_CLICK, INLINE_SELECTION_IMPRESSION, MESSAGE_CLICK, MESSAGE_DISMISS, MESSAGE_IMPRESSION, MESSAGE_SET, MESSAGE_TOGGLE_VISIBILITY, NEW_TAB_INIT, NEW_TAB_INITIAL_STATE, NEW_TAB_LOAD, NEW_TAB_REHYDRATED, NEW_TAB_STATE_REQUEST, NEW_TAB_UNLOAD, OPEN_ABOUT_FAKESPOT, OPEN_DOWNLOAD_FILE, OPEN_LINK, OPEN_NEW_WINDOW, OPEN_PRIVATE_WINDOW, OPEN_WEBEXT_SETTINGS, PARTNER_LINK_ATTRIBUTION, PLACES_BOOKMARKS_REMOVED, PLACES_BOOKMARK_ADDED, PLACES_HISTORY_CLEARED, PLACES_LINKS_CHANGED, PLACES_LINKS_DELETED, PLACES_LINK_BLOCKED, PLACES_SAVED_TO_POCKET, POCKET_CTA, POCKET_LINK_DELETED_OR_ARCHIVED, POCKET_LOGGED_IN, POCKET_THUMBS_DOWN, POCKET_THUMBS_UP, POCKET_WAITING_FOR_SPOC, PREFS_INITIAL_VALUES, PREF_CHANGED, PREVIEW_REQUEST, PREVIEW_REQUEST_CANCEL, PREVIEW_RESPONSE, REMOVE_DOWNLOAD_FILE, REPORT_CLOSE, REPORT_OPEN, RICH_ICON_MISSING, SAVE_SESSION_PERF_DATA, SAVE_TO_POCKET, SCREENSHOT_UPDATED, SECTION_DEREGISTER, SECTION_DISABLE, SECTION_ENABLE, SECTION_OPTIONS_CHANGED, SECTION_REGISTER, SECTION_UPDATE, SECTION_UPDATE_CARD, SETTINGS_CLOSE, SETTINGS_OPEN, SET_PREF, SHOW_DOWNLOAD_FILE, SHOW_FIREFOX_ACCOUNTS, SHOW_PERSONALIZE, SHOW_PRIVACY_INFO, SHOW_SEARCH, SHOW_TOAST_MESSAGE, SKIPPED_SIGNIN, SOV_UPDATED, SUBMIT_EMAIL, SUBMIT_SIGNIN, SYSTEM_TICK, TELEMETRY_IMPRESSION_STATS, TELEMETRY_USER_EVENT, TOPIC_SELECTION_IMPRESSION, TOPIC_SELECTION_MAYBE_LATER, TOPIC_SELECTION_SPOTLIGHT_CLOSE, TOPIC_SELECTION_SPOTLIGHT_OPEN, TOPIC_SELECTION_USER_DISMISS, TOPIC_SELECTION_USER_OPEN, TOPIC_SELECTION_USER_SAVE, TOP_SITES_CANCEL_EDIT, TOP_SITES_CLOSE_SEARCH_SHORTCUTS_MODAL, TOP_SITES_EDIT, TOP_SITES_INSERT, TOP_SITES_OPEN_SEARCH_SHORTCUTS_MODAL, TOP_SITES_ORGANIC_IMPRESSION_STATS, TOP_SITES_PIN, TOP_SITES_PREFS_UPDATED, TOP_SITES_SPONSORED_IMPRESSION_STATS, TOP_SITES_UNPIN, TOP_SITES_UPDATED, TOTAL_BOOKMARKS_REQUEST, TOTAL_BOOKMARKS_RESPONSE, UNBLOCK_SECTION, UNFOLLOW_SECTION, UNINIT, UPDATE_PINNED_SEARCH_SHORTCUTS, UPDATE_SEARCH_SHORTCUTS, WALLPAPERS_CATEGORY_SET, WALLPAPERS_CUSTOM_SET, WALLPAPERS_FEATURE_HIGHLIGHT_COUNTER_INCREMENT, WALLPAPERS_FEATURE_HIGHLIGHT_CTA_CLICKED, WALLPAPERS_FEATURE_HIGHLIGHT_DISMISSED, WALLPAPERS_FEATURE_HIGHLIGHT_SEEN, WALLPAPERS_SET, WALLPAPER_CATEGORY_CLICK, WALLPAPER_CLICK, WALLPAPER_REMOVE_UPLOAD, WALLPAPER_UPLOAD, WEATHER_IMPRESSION, WEATHER_LOAD_ERROR, WEATHER_LOCATION_DATA_UPDATE, WEATHER_LOCATION_SEARCH_UPDATE, WEATHER_LOCATION_SUGGESTIONS_UPDATE, WEATHER_OPEN_PROVIDER_URL, WEATHER_QUERY_UPDATE, WEATHER_SEARCH_ACTIVE, WEATHER_UPDATE, WEBEXT_CLICK, WEBEXT_DISMISS'
[task 2025-03-26T03:29:25.066Z] @http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:96280:12
[task 2025-03-26T03:29:25.066Z] 
[task 2025-03-26T03:29:25.066Z] TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | activity-stream:<AdBannerContextMenu>:Ad banner context menu options "before each" hook for "should render a context menu button": can't access property "discoverystream.reportContent.enabled", prefs is undefined
[task 2025-03-26T03:29:25.066Z] AdBannerContextMenu@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:152086:50
[task 2025-03-26T03:29:25.066Z] render@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:37057:32
[task 2025-03-26T03:29:25.066Z] renderElement@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:1937:42
[task 2025-03-26T03:29:25.066Z] createShallowRenderer/render/<@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:2018:24
[task 2025-03-26T03:29:25.066Z] withSetStateAllowed@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:73860:16
[task 2025-03-26T03:29:25.066Z] render@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:2017:66
[task 2025-03-26T03:29:25.066Z] ShallowWrapper@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:71500:22
[task 2025-03-26T03:29:25.066Z] shallow@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:73636:10
[task 2025-03-26T03:29:25.066Z] @http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:222534:64
[task 2025-03-26T03:29:25.066Z] 
[task 2025-03-26T03:29:25.066Z] TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | activity-stream:<DSCard> should render badges for pocket, bookmark when not a spoc element : Error: Could not find "store" in the context of "Connect(_DSLinkMenu)". Either wrap the root component in a <Provider>, or pass a custom React context provider to <Provider> and the corresponding React context consumer to Connect(_DSLinkMenu) in connect options. (http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:114513)
[task 2025-03-26T03:29:25.066Z] invokeGuardedCallbackDev@http://localhost:9876/absolute/tmp/_karma_webpack_726766/commons.js?5c4cbf01b441dfffc765da76d94d34d286920a26:6030:1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31637ac2869d
Build reporting UI. r=home-newtab-reviewers,fluent-reviewers,frontend-codestyle-reviewers,mossop,nbarrett,bolsson

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out changeset 31637ac2869d (Bug 1954653) for causing newtab failures.

Push with failures

Failure log

Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/331377959f1d
Build reporting UI. r=home-newtab-reviewers,fluent-reviewers,frontend-codestyle-reviewers,mossop,nbarrett,bolsson

Comment 7

[Cristian Tuns]

Backed out for causing newtab failures in activity-stream.html

• Backout link
• [Push with failures](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnewtab&revision=331377959f1dc00eb4a8708c53a3f0e832d730bb&selectedTaskRun=TCn_HP1PQyqpNsec6OkDxA.0
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | bundles | activity-stream.html out of date

Comment 8

[Reem Hamoui]

Patch is failing to land due to a bundling/linting error loop that I can't seem to find a fix for.
I've created a ticket that could hopefully get more eyes on it:
https://bugzilla.mozilla.org/show_bug.cgi?id=1956978

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7580d81f6124
Build reporting UI. r=home-newtab-reviewers,fluent-reviewers,frontend-codestyle-reviewers,mossop,nbarrett,bolsson

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7580d81f6124