1954685 - Unship onafterscriptexecute and onbeforescriptexecute events on Nightly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Edgar Chen [:edgar]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1584269#c14 for details.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1954685 - Unship onafterscriptexecute and onbeforescriptexecute events on Nightly; r?#dom-core

Comment 2

[Edgar Chen [:edgar]]

Our JS test harness waits for afterscriptexecute to ensure the module scripts are executed in a sequence, see https://searchfox.org/mozilla-central/rev/ac605820636c3b964542a2c0589af04a02235d00/js/src/tests/browser.js#529-530,557. I don't have a better alternative way to detect when a module script has executed, so I am going to keep this event firing, but only on system group.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fbd18fe19d5
Unship onafterscriptexecute and onbeforescriptexecute events on Nightly; r=dom-core,webidl,saschanaz,devtools-reviewers,ochameau,hsivonen,jandem

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3fbd18fe19d5

Comment 5

[Florin Bilt]

(In reply to Narcis Beleuzu [:NarcisB] from comment #4)

https://hg.mozilla.org/mozilla-central/rev/3fbd18fe19d5

Perfherder has detected a awsy performance change from push c3069c78f8803e975da9290df35f312955815401.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.26%	Base Content JS	windows11-64-24h2-shippable	fission	1,545,024.00 -> 1,541,008.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44573

The following documentation link provides more information about this command.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Should we call this out in the Nightly relnotes? Please add a relnote-firefox? nomination if yes.

Comment 7

[Edgar Chen [:edgar]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We are disabling Firefox only feature that is not defined in the spec
[Affects Firefox for Android]: Yes
[Suggested wording]: Stop dispatching afterscriptexecute and beforescriptexecute events on Nightly.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Document/beforescriptexecute_event and https://developer.mozilla.org/en-US/docs/Web/API/Document/afterscriptexecute_event

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Added to the nightly relnotes.

Comment 9

[Hamish Willee]

Will this also stop dispatching the Element versions of these events? Such as https://developer.mozilla.org/en-US/docs/Web/API/Element/afterscriptexecute_event ?

Comment 10

[Edgar Chen [:edgar]]

(In reply to Hamish Willee from comment #9)

Will this also stop dispatching the Element versions of these events? Such as https://developer.mozilla.org/en-US/docs/Web/API/Element/afterscriptexecute_event ?

Yes, this also stop dispatching those events on Element, too.

Comment 11

[Hamish Willee]

Thanks!

FF139 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/39304 (is essentially just release note/Experimental feature page update)

Comment 12

[Dianna Smith [:diannaS]]

Moving out of nightly release notes since this was unshipped in early beta in bug 1964343 in fx140