1954803 - Use webrender for view transition's "old" snapshots.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1954803 - Hook view transitions "old snapshot" code path to webrender as well. r=nical,#vt

This seems to do what I'd expect on the Gecko side, but the snapshots
still don't show up without this change.

Also adds some logging infrastructure.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Nical, any idea why this doesn't seem to work? The snapshots of the old content almost never show up. The fact that's "almost never" kinda hints at something going wrong on the WR side... Maybe another frame arrives and thus we never actually take the snapshot?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

(Note that I wrote this behind a pref, you need to turn the pref on to see the bug)

Comment 4

[Emilio Cobos Álvarez [:emilio]]

If I turn on missing-snapshot-panic then it well, panics. But interestingly the missing-snapshot-pink pref doesn't seem to work.

Comment 5

[Nicolas Silva [:nical]]

missing-snapshot-panic should panic here. If it panics here it means that we have created a snapshot image key but for some reason it didn't get rendered. If the panic happens elsewhere, the issue is likely that the image key wasn't created in the first place. As we discussed earlier that could be caused by a transaction not being rendered. I filed bug 1955005 to address that particular concern.

missing-snapshot-pink also only affects snapshot image keys that were created but not rendered.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1954803 - Enable using WR for old captures. r=nical,#vt

Test expectation updates incoming.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc8468453de2
Hook view transitions "old snapshot" code path to webrender as well. r=nical

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e39769e47f14
Pass current ASR to avoid debug-only asserts.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/758f044d69df
Annotate some flaky tests.

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fc8468453de2
https://hg.mozilla.org/mozilla-central/rev/e39769e47f14
https://hg.mozilla.org/mozilla-central/rev/758f044d69df

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c515e7a5c79
Enable using WR for old captures. r=view-transitions-reviewers,boris

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f8dc7310705
Update test expectations for old-content-inline-with-offset-from-containing-block-clipped.html CLOSED TREE

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c515e7a5c79

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31fcde778a80
Annotate a few flakes.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6944d14565f
Annotate a few tests that now pass on windows, and another flake.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c79d40512b18
Another round of annotations for frequent oranges. a=test-only

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0f8dc7310705
https://hg.mozilla.org/mozilla-central/rev/31fcde778a80
https://hg.mozilla.org/mozilla-central/rev/a6944d14565f

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c79d40512b18