Closed Bug 1954854 Opened 5 months ago Closed 5 months ago

xpidl out parameters that are turned into return types for JavaScript should not be marked as OutParam<> in TypeScript

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox138 fixed)

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If we have an interface function defined in idl as:

void readBytes(in uint32_t aLength, [size_is(aLength), retval] out string aString);

then we're currently generating the typescript interface as:

readBytes(aLength: u32): OutParam<string>;

However, the JavaScript generated interface is returning the simple string. Hence we shouldn't be wrapping it as an OutParam.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f2f65597c28 When generating TypeScript interfaces via xpidl, fix the return type when translating out parameters. r=zombie
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: