1955036 - Focus outlines (highlights) on edit icon from profiles account menu items using keyboard navigation doesn't look like Figma specs

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Attachment: Screenshot 2025-03-19 142723.png

Found in:
Nightly 138.0a1

Affected versions:
Nightly 138.0a1

Tested platforms:

Affected platforms: Windows 11, macOS 13.2.1
Unaffected platforms:

Preconditions:
Make sure that the pref "browser.profiles.enabled" is set to true in about:config.
Create at least one profile.

Steps to reproduce:

1. Navigate to Account menu from toolbar using keyboard.
2. Navigate to [profile name] and open the profiles menu using keyboard
3. Navigate to [Edit] icon using keyboard.
4. Observe the focus outlines(highlights) on [Edit] icon.

Expected result:
The focus outlines(highlights) on [Edit] icon from account menu should look like Figma specs.

Actual result:
A double focus outlines are displayed on the [Edit] icon. Please see the screenshot.

Regression range:
This is not a regression; it's introduced with the Profile Switcher feature.

Additional notes:
On Hamburger menu the focus outlines on [Edit] icon is according to Figma specs.

Comment 1

[Cieara Meador [:cmkm]]

Attachment: Bug 1955036 - Eliminate double focus outline on profile edit button r?#profiles-reviewers

When the profiles menu is opened via the FxA accounts toolbar button, it
gets a focus outline on both the toolbarbutton and toolbarbutton-icon.
This doesn't happen when opening the menu from the hamburger button.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

From KimB: the double focus ring isn't pretty but isn't a blocker (provided this doesn't break assistive tech / screen reader).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/457b4caf28a5
Eliminate double focus outline on profile edit button r=profiles-reviewers,desktop-theme-reviewers,Itiel,emilio,mossop

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/457b4caf28a5

Comment 5

[Raluca Popovici, Desktop QA]

Verified as fixed on Windows 11 and macOS 13.2.1 using Nightly 138.0a1 (2025-03-30)