1955078 - Re-opening about:credits does not redirect

Status: NEW

(Core :: DOM: Security, defect, P2)

Description

[Beth Rennie [:beth] (she/her)]

STR

1. Open about:credits
2. Close the tab
3. Re-open the tab via cmd+shift+tab / ctrl+shift+tab

ER

The tab should re-open https://www.mozilla.org/credits/

AR

The tab re-opens about:credits and does not redirect to https://www.mozilla.org/credits/

Comment 1

[Sarah Clements [:sclements]]

This is pretty strange. It also happens if you try to reopen a tab via the app menu > History > recently closed tabs.

:farre, is there a reason you don't think this is a navigational issue and is instead a session restore issue? :)

Comment 2

[Andreas Farre [:farre]]

Yeah, sorry for not giving an explanation. This has usually been an issue about either the final tabstate update not being enough, and that a call to TabStateFlusher.flush() is needed.

But the strange thing is that even if I wait for the buffer to time out it reproduces. And I can't really get it to reproduce with other about pages. Not even about:rights which should be very similar, insofar that it is an https and has the same flags.

If you wan't I can try to find some time to look at what TabStateCache.sys.mjs actually has saved at this point, because that should give an indication of what's going on.

Comment 3

[Sarah Clements [:sclements]]

(In reply to Andreas Farre [:farre] from comment #2)

If you wan't I can try to find some time to look at what TabStateCache.sys.mjs actually has saved at this point, because that should give an indication of what's going on.

It would be good to find out what's causing this, if you're able to look into that. :)

Comment 4

[Andreas Farre [:farre]]

This is actually findable with mozregression.

Olli, do you have an idea of what's going on here?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, that is the kind of case bug 1905843 is trying to prevent.
Is it overly strict in this case? thinking

Comment 7

[Vincent Hilla [:vhilla]]

There's a warning that indicates an early return in nsHttpChannel::AsyncOpen due to nsContentSecurityManager::CheckForIncoherentResultPrincipal

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1905843