1955158 - Scrolling hangs on https://tuwel.tuwien.ac.at (moodle instance) on desktop

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P1)

Description

[Hiroyuki Ikezoe (:hiro)]

And disable it on desktops by default to mitigate regression such as bug 1950744, and enable it on Android by default.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1955158 - Make __visual__ scroll-into-view to position:fixed frames behind a pref. r?botond,dlrobertson

And disable the pref on desktops by default, enable it on Android by
default.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90dbec9f0f4c
Make __visual__ scroll-into-view to position:fixed frames behind a pref. r=botond

Comment 3

[Atila Butkovits]

Backed out for causing failures at compile-event-handler-settings-objects.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b3f9c1856c0405e2f0b515981020946dab2de65a

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=biyqbSMuT8Gs5cA6VaU3Lg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7d198c9f032e6c16d7f9798c504b3b5708ce9760

Failure log: https://treeherder.mozilla.org/logviewer?job_id=500248839&repo=autoland&lineNumber=3495

Comment 4

[Hiroyuki Ikezoe (:hiro)]

The failure is unlikely caused by my change. https://hg.mozilla.org/integration/autoland/rev/a420e4797f0275b158d9f639f87617cdfb574a2f would be more suspicious.

Atila, would you mind retriggering the test task on the backed out change to see whether the failure still persists or not? If it still persists, which means my change isn't the culprit. Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a871c731da19
Make __visual__ scroll-into-view to position:fixed frames behind a pref. r=botond

Comment 6

[Atila Butkovits]

We relanded your changeset, we created this bug to track the issue.

Sorry for the trouble.

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a871c731da19

Comment 8

[Pascal Chevrel:pascalc]

Could we have an uplift request since that fixes bug 1950744? Thanks

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1955158 - Make __visual__ scroll-into-view to position:fixed frames behind a pref. r=botond

And disable the pref on desktops by default, enable it on Android by
default.

Original Revision: https://phabricator.services.mozilla.com/D242252

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Moodle instances are unusable on some pages (scrolling keeps jumping up to the top)
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Patch puts a previous change behind a pref, restoring the previous behaviour on desktop
• String changes made/needed: none
• Is Android affected?: yes

Comment 11

[Botond Ballo [:botond]]

(In reply to Pascal Chevrel:pascalc from comment #8)

Could we have an uplift request since that fixes bug 1950744? Thanks

I made the request.

Comment 12

[Botond Ballo [:botond]]

(In reply to Phabricator Automation from comment #10)

• Is Android affected?: yes

To clarify: Android is affected by the bug, but not fixed by this mitigation which is desktop-only.

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Thank you, Botond!

Comment 14

[Pascal Chevrel:pascalc]

The patch for uplift does not apply cleanly to the beta branch, looks like it wants to patch a file that doesn't exist in beta:

unable to find 'gfx/layers/apz/test/mochitest/test_group_scrollIntoView.html' for patching
https://phabricator.services.mozilla.com/D242641

Could you provide a rebased patch? Thanks

Comment 15

[Botond Ballo [:botond]]

Rebased. I dropped the changed the test_group_scrollIntoView.html since that's a test added in 138 that has not been uplifted to 137.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cc366a853509

Comment 17

[Botond Ballo [:botond]]

Updating bug title and flags to use this bug to track the desktop version of the Moodle regression originally filed at bug 1950744.

I also updated the firefox-137 status to "disabled" because I believe that's more accurate. The regressing codepath is potentially applicable to desktop as well, and we disabled it on desktop in this bug. When the underlying issue is fixed in bug 1950744, I expect we will re-enable it.