1955175 - VMFunctions and ABIFunctions are not fully checked for fully qualified names, and cannot have multiple template parameters

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Steve Fink [:sfink] [:s:]]

For example, js::ConcatStrings<CanGC> is allowed because ::js::ConcatStrings<CanGC> works, but actually the js namespace must be getting imported everywhere this is checked, because CanGC is really js::CanGC.

Also, js::Foo<CharT, js::CanGC> is rejected because the macro invocation sees separate parameters due to the comma.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1955175 - Properly check the VMFunction and ABIFunction lists for proper qualification, and enable the use of templatized functions with more than 1 template parameter r=jandem

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1a0ded86d38
Properly check the VMFunction and ABIFunction lists for proper qualification, and enable the use of templatized functions with more than 1 template parameter r=jandem

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out changeset f1a0ded86d38 (Bug 1955175) for SM failures on ABIFunctionList

Push with failures

Failure log

Backout link

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8196faa8a263
Properly check the VMFunction and ABIFunction lists for proper qualification, and enable the use of templatized functions with more than 1 template parameter r=jandem

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8196faa8a263