1955235 - Remove inline style from CodeMirror addon/search

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Tom Schuster [:tschuster]]

The following sets an inline style attribute using JS: https://searchfox.org/mozilla-central/source/devtools/client/shared/sourceeditor/codemirror/addon/search/search.js#234,239,256. They should be replaced with code like elem.style.width = "20em";.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1955235 - [devtools] Remove inline style from codemirror search addon. r=#devtools.

Instead use the class that are set on the elements to add CSS rules in mozilla.css.
The classes are renamed to make it clear they're for CodeMirror 5.
The style of the element is slightly tweaked to use our theme variables, and we
set proper focus indicator on the search/replace input.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edfa3a7c50d9
[devtools] Remove inline style from codemirror search addon. r=devtools-reviewers,ochameau.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/edfa3a7c50d9