Closed
Bug 1955339
Opened 1 year ago
Closed 1 year ago
Remove inline style from CodeMirror keymap/vim.js
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox138 fixed)
RESOLVED
FIXED
138 Branch
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: tschuster, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
| Assignee | ||
Comment 1•1 year ago
|
||
The input element wasn't rendered anymore ("Flattening unsafe node"), so build a document fragement
instead of constructing the string for the prompt element.
Instead of adding inline style, we put CSS classes on the elements
for which we add rules in mozilla.css.
The styles are slightly tweaked so we use the colors from the DevTools theme,
and show proper focus indicator.
Updated•1 year ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab8c0f80fae5
[devtools] Fix and refactor CodeMirror keymap/vim.js prompt. r=devtools-reviewers,ochameau.
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•