Closed Bug 1955387 Opened 1 year ago Closed 1 year ago

Add locale fallback handling to the Rust based search engine selector

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

VERIFIED FIXED

People

(Reporter: standard8, Assigned: mcheang)

References

Details

(Whiteboard: [sng])

Attachments

(1 external file)

To better support the locale handling for mobile, we need to add a fallback option within the search engine selector.

The fallback will look at the locales listed in the search configuration and:

  • If the user's locale matches one specified, use that locale as-is for matching environments.
  • If it doesn't match, it will strip of the regional part (i.e. de-AT becomes de) and then use that for matching environments.

There's a couple of options for how we do this:

  1. To find the list of locales, iterate over the whole search configuration and examine the variant & sub-variant environments for possible locales.
  2. Add a list of all the locales as a new record type in the search configuration.

I think the second option is probably better - it simplifies the potentially expensive task of checking for locales in use. However, it does have the downside that we'll have an additional list to keep up to date - though we can add a test for it to test_searchconfig_validates.js.

Assignee: nobody → mcheang
Depends on: 1962751

Authored by https://github.com/mandysGit
https://github.com/mozilla/application-services/commit/6813dc9333bdae7ca88c7126e26f8f41759b9ddf
[main] Bug 1955387 - Add locale fallback handling to the Rust based search engine selector.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: qe-verify+
Resolution: --- → FIXED

This fix was covered and subsequently verified by the Search Consolidation - Desktop Rollout QA-3246 feature run.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: