Closed Bug 19554 Opened 20 years ago Closed 19 years ago

[Skins] Global skin must contain all font/color/border info

Categories

(SeaMonkey :: Themes, defect, P4)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: hyatt, Assigned: hewitt)

References

Details

(Whiteboard: [nsbeta2-] [nsbeta3-])

Need to change things so that the global skin is sufficiently rich to be used
for all font, color, and border info.  No derived skin should ever contain this
info.
spam: changing qa contact from ckritzer -> paulmac for xul bugs
Adding [beta], since we will be localizig it, and making a dependency for 12394.
Target Milestone: M13 → M15
targetting M15
These are pre-requisites of localizable chrome. Marking them [BETA]. Please fix
them by M14 so that we can be ready for localization. To make the chrome
localizable, the font name, font size, and UI geometry setting needs to be
externalized and move to chrome/[package]/locale/*.css.

Adding lyecies, amasri, and tao into CC list.


Thanks
Summary: [Skins] Global skin must contain all font/color/border info → [BETA][Skins] Global skin must contain all font/color/border info
Target Milestone: M15 → M16
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Two bugs where things that shouldn't be able to are changing colours of UI
elements in the default skin for Mozilla:

Bug 25349, "sidebar, dialogs using Win32 text colour; bad UI if white"

Bug 24919, "browser text colour prefs affect chrome as well as content"
Due to Beta indication in Summary, putting beta1 into keyword field.
Keywords: beta1
Is this needed for Browser skin?
Summary: [BETA][Skins] Global skin must contain all font/color/border info → [Skins] Global skin must contain all font/color/border info
Whiteboard: [NEED INFO]
Depends on whether or not you want the app to be skinnable in beta1.  We already 
know there won't be a UI way to skin the app in beta1.  If this bug isn't fixed, 
you won't be able to write skins off of beta1 at all.
Whiteboard: [NEED INFO] → [PDT+]
You should realize that truly fixing this bug will involve an enormous amount of 
work, and it involves fixing the 20 dependent bugs for each individual 
component.  You are basically committing to having a skinnable product in beta.

This task will probably involve at least a week's worth of work on the part of 
german, ben, hangas, and myself, and would drag in other component UI owners as 
well.  

I do think it's worth shooting for.  Just making sure you realize what you're 
getting us into.  This bug is very large.
Removing for reconsideration.
Whiteboard: [PDT+] → [PDT]
Given the amount open bugs, we should probably just bite the bullet and admit 
that we won't be skinnable in the least in beta1.
Per last comment, putting on the PDT- radar for beta1.
Whiteboard: [PDT] → [PDT-]
QA Contact: paulmac → jrgm
*IGNORE* - more massive spam, changing open XPToolkit bug's QA contact to
jrgm@netscape.com

Adding 'skins' keyword to appropriate bugs en masse, sorry about any 
mistakes...
Keywords: skins
...
Assignee: hyatt → ben
Status: ASSIGNED → NEW
Keywords: beta1beta2
Whiteboard: [PDT-]
Blocks: 29160
Mass-adding beta2 keyword to all skins bugs.
Keywords: nsbeta2
Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.
Whiteboard: [nsbeta2+][5/16]
Move to M19.
Target Milestone: M16 → M19
Putting on [nsbeta2-] radar, removing 5/16.  Did not make the Netscape 6 train.
Whiteboard: [nsbeta2+][5/16] → [nsbeta2-]
Target Milestone: M19 → M20
M20
Nav triage team: setting to "future"
Whiteboard: [nsbeta2-] → [nsbeta2-] [nsbeta3-]
Target Milestone: M20 → Future
re-assigning to Paul Hangas
Assignee: ben → hangas
Note we are trying to reduce the scope of skins to meet schedules, happy to 
discuss.  Other skin bugs being Futured include bug 39336 and bug 19562.
Status: NEW → ASSIGNED
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.
Keywords: nsbeta3
Keywords: skins
Assignee: hangas → hewitt
Status: ASSIGNED → NEW
Component: XP Toolkit/Widgets: XUL → Themes
QA Contact: jrgm → pmac
Sending to Joe
Status: NEW → ASSIGNED
Priority: P3 → P4
Themes Triage Team marking fixed because changes in skins for Mojo will redefine 
the structure of a skin.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
After speaking with David Hyatt, this bug is marked as invalid.
Marking verified.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.