1955492 - Figure out the combination of valid-lazy rule and using declareLazy/defineLazy

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Tomislav Jovanovic :zombie]

We probably want to make the valid-lazy rule work with the new design of declareLazy() (from bug 1945464), or at least defineLazy(this, ...) usage, because TS doesn't actually understand it and we'll need to fall back to eslint for checking it.

Comment 1

[Rob Wu [:robwu]]

Bug 1960233 (https://phabricator.services.mozilla.com/D245364 ) added 31 new uses of /* eslint-disable mozilla/valid-lazy */ to basically the whole extension framework.

In response to my question "What is the path towards restoring valid-lazy?", Tom replied with:

Mark mentioned he's going to do a similar patch to this one in toolkit/components/search later this week, so I expect he'll probably have a better idea what we might do after that.

So, just to make sure that this doesn't fall through the cracks - Mark, is there a path towards restoring valid-lazy coverage for extension code?

Comment 2

[Mark Banner (:standard8)]

The existing valid-lazy rule needs either to support the new functions, or a second rule written which supports those (and adapt the current one to ignore).

At the moment I probably won't get to those for a week or two as I have other priorities. I'm happy if anyone else wants to take a look though.

Comment 3

[Moritz Beier [:mbeier]]

Attachment: Bug 1955492 - Make valid-lazy work with XPCOMUtils.declareLazy. r?standard8

Comment 4

[Moritz Beier [:mbeier]]

Attachment: Bug 1955492 - Re-enable valid-lazy in extensions code. r?robwu

Comment 5

[Moritz Beier [:mbeier]]

Attachment: Bug 1955492 - Re-enable valid-lazy in extensions code. r?robwu

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9dc9340a0a55
https://hg.mozilla.org/integration/autoland/rev/14bae16f0f06
Make valid-lazy work with XPCOMUtils.declareLazy. r=Standard8,frontend-codestyle-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e8d5a4994d05
https://hg.mozilla.org/integration/autoland/rev/ae2e418b1292
Re-enable valid-lazy in extensions code. r=robwu

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14bae16f0f06

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ae2e418b1292