1955560 - ./mach test browser/components/asrouter/tests/unit/ASRouter.test.js should work

Status: NEW

(Firefox :: Messaging System, task, P2)

Description

[Florian Quèze [:florian]]

$ ./mach test browser/components/asrouter/tests/unit/ASRouter.test.js
UNKNOWN TEST: browser/components/asrouter/tests/unit/ASRouter.test.js
I was unable to find tests from the given argument(s).

You should specify a test directory, filename, test suite name, or
abbreviation.

It's possible my little brain doesn't know about the type of test you are
trying to execute. If you suspect this, please request support by filing
a bug at
https://bugzilla.mozilla.org/enter_bug.cgi?product=Testing&component=General.

I feel like it's not the first time I waste time trying to figure out how to run this test (that I need to debug because it fails in one of my try pushes).

Comment 1

[Florian Quèze [:florian]]

For future reference, there's some documentation at https://firefox-source-docs.mozilla.org/browser/components/asrouter/docs/building-and-testing.html

And the commands to run are:

./mach npm install && cd browser/components/asrouter && ../../../mach npm install && cd -
./mach npm test --prefix=browser/components/asrouter

Comment 2

[Florian Quèze [:florian]]

And to avoid running all the linters before the tests: ./mach npm run testmc:unit --prefix=browser/components/asrouter

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Thanks for the detailed bug filing!

I believe that fixing bug 1810365 would effectively make this problem go away. However, that's a bunch of work, and I think there's a good chance it would be straightforward to teach mach to detect this sort of failure in browser/components/{asrouter,aboutwelcome} and print out a message that both links to the documentation page florian mentioned, and proposes that the developer immediately try what Florian proposes:

./mach npm install && cd browser/components/asrouter && ../../../mach npm install && cd -
./mach npm run testmc:unit --prefix=browser/components/asrouter