Closed Bug 1955567 Opened 7 months ago Closed 6 months ago

Search bar has large gaps above/below it when moved to the overflow menu in customize mode

Categories

(Firefox :: Toolbars and Customization, defect, P5)

Product:
Firefox
Component:
Toolbars and Customization
Version:
Firefox 137
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox136 --- wontfix
firefox137 --- wontfix
firefox138 --- wontfix
firefox139 --- fixed

People

(Reporter: tzsoldos, Assigned: brian.zhou.ouyang)

References

(Regression)

Details

(Keywords: good-next-bug, regression)

Attachments

(2 files)

Search-Bar_position.png
59.00 KB, image/png
Details
Bug 1955567 - Fix spacing of search bar in overflow menu in customize mode. r?Gijs!
48 bytes, text/x-phabricator-request
Details | Review
Attached image Search-Bar_position.png —

Affected versions

  • Firefox 138.0a1
  • Firefox 137.0b7
  • Firefox 136.0.2

Affected platforms

  • Windows 11, macOS 12

Steps to reproduce

  1. Drag and drop the Search Bar to the Overflow Menu.

Expected result

  • The Search bar position should be the first line from the list, even here in customize mode.

Actual result

  • The Search Bar is forcibly added to a lower position in the list in customize mode.

Regression range

  • I will come back with regression range ASAP.

Additional note

  • This issue occurs only when the Search Bar is added, any other items are added to the first position.
  • The Search Bar wrong position is observed only in customize mode, issue is reflected in the attached screenshot.
Component: about:logins → Toolbars and Customization
Summary: Search bar is added at a wrong position in overflow menu customize mode → Search bar is added in a wrong position in overflow menu customize mode

Given this is only in customize mode, the ordering is correct and adding more items hides the bug, this is probably S4. But fixing this should also be straightforward: the #wrapper-search-container gets a lot of flex in https://searchfox.org/mozilla-central/rev/3a0ca3dffd7ccf74a53066a097739f24dd8b6b10/browser/themes/shared/urlbar-searchbar.css#1012 and that should be avoided in the panel. Before the regressing bug there was a rule overriding the flex property.

Severity: normal → S4
status-firefox136: affected → wontfix
status-firefox137: affected → wontfix
status-firefox138: --- → fix-optional
status-firefox-esr128: --- → wontfix
Keywords: good-next-bug, regression
OS: Unspecified → All
Priority: -- → P5
Regressed by: 1902314
Summary: Search bar is added in a wrong position in overflow menu customize mode → Search bar has large gaps above/below it when moved to the overflow menu in customize mode

:dao, since you are the author of the regressor, bug 1902314, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(dao+bmo)
Assignee: nobody → brian.zhou.ouyang
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/435b2804dbb5 Fix spacing of search bar in overflow menu in customize mode. r=Gijs,desktop-theme-reviewers,search-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/435b2804dbb5

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
QA Contact: tzsoldos
QA Whiteboard: [qa-triage-done-c140/b139]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: