1955583 - Right-click the PIP icon should show menu, but it launches PIP (while briefly showing a flash of the menu)

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Paul (FxUX)]

Expected:
When playing a video, right clicking the picture-in-picture icon should show a context menu.

Actual:
Right clicking the PIP icon does the same as a left-click – it launches the picture-in-picture window.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi Paul,

Are you referring to the icon in the URL bar? Or the toggle on the video itself?

Comment 3

[Paul (FxUX)]

The toggle in the video itself.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: contextmenu test

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hi Paul,

If you open this test page, and right click on any of the white area of the page, does it add a "context menu opened" message?

Comment 6

[Paul (FxUX)]

Yes, it does. Thanks Mike!

Comment 7

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mconley, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[kpatenio]

Hi Paul,

Does this happen for all videos? Would you mind sharing some videos links where you noticed the issue? And lastly, what OS are you using?

I'm wondering if this could be a problem with a site, or something else entirely.

Comment 9

[Paul (FxUX)]

Thanks Katherine!

All videos on YouTube.com

Using Mac OS 14.6.1

I've sent you a video on Slack (it's too large to upload here)

Comment 10

[kpatenio]

Thanks Paul. In case it helps others, I'll document what we briefly discussed on Slack:

• issue was spotted in Nightly 139.0a1
• machine is a M3 MBP (November 2023), macos 14.6.1 like previously stated
• no extensions were enabled
• we verified the prefs in about:config. No immediate problems stood out to me. Even media.videocontrols.picture-in-picture.visibility-threshold was set to the default 1.0.

Despite having similar specs, I could not reproduce the issue from my end. If you don't mind checking again, Paul, do you still see the buggy behaviour on the latest Nightly?

Comment 11

[Paul (FxUX)]

Attachment: Showing PIP right click bug

Comment 12

[Paul (FxUX)]

Yes, the issue still persists in the latest Nightly

Comment 13

[kpatenio]

Gotcha, thanks for the speedy reply. I'll mark this as a p3/s3 for the time being.

Comment 14

[Paul (FxUX)]

I should add a detail that wasn't in the original ticket.

When I right click, the menu briefly shows before the PIP video pops out.

Shown in the GIF file that I shared a few minutes ago.

Comment 15

[kpatenio]

I should add a detail that wasn't in the original ticket.

When I right click, the menu briefly shows before the PIP video pops out.

Shown in the GIF file that I shared a few minutes ago.

Hmm, yeah it's odd that the menu appears briefly before PiP opens. Seems to be interference between YouTube's event handling on the video element and the PiP toggle. Might be worth investigating too if the problem occurs on other video sites.

Ex. try right clicking the toggle with this video: https://vimeo.com/channels/smashingconf

Comment 16

[Paul (FxUX)]

Just tried Vimeo. Same issue as YouTube.

Comment 17

[kpatenio]

Ah, actually I forgot about control + click; with it, I'm able to reproduce the problem. It acts like right click, but is apparently recognized as a primary click (event.button = 0) and doesn't satisfy the condition at this line to stop PiP from triggering. We may want to check if event.button == 0, but ensure there are no other modifiers.

Comment 18

[Paul (FxUX)]

Sorry for the wild goose-chase!

I use a trackpad, so I use CTRL+click for what is commonly known as 'right click'

It didn't even cross my mind that I wasn't literally "right clicking" with a mouse.

Comment 19

[kpatenio]

Attachment: Bug 1955583 - stop PiP from opening and instead show context menu on macOS ctrl+click. r=#pip-reviewers!

Comment 20

[kpatenio]

(In reply to Paul from comment #18)

Sorry for the wild goose-chase!

I use a trackpad, so I use CTRL+click for what is commonly known as 'right click'

It didn't even cross my mind that I wasn't literally "right clicking" with a mouse.

No worries! I have a WIP patch up since I have cycles to spare.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4362d5ac46a
stop PiP from opening and instead show context menu on macOS ctrl+click. r=pip-reviewers,mconley

Comment 22

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e4362d5ac46a

Comment 23

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 140.0a1 (2025-05-20) on macOS 12. Using Control + Click on the PiP video button will open PiP.
The issue is verified fixed with Firefox 140.0b2 on macOS 12. The context menu is correctly open when using Control + Click on the PiP video button.