1955638 - Custom Wallpaper UUID pref should reset when wallpaper is set to default

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Maxx Crawford [:maxx]]

Note - this is an edge case pref issue. From a user-standpoint, this behavior works as expected.

1. Open new tab
2. Open Customize Panel - Click gear icon (⚙️) in corner to
3. Click "Upload an mage" tile to upload custom wallpaper
4. Upload a custom wallpaper
5. In about:config, confirm the pref browser.newtabpage.activity-stream.newtabWallpapers.customWallpaper.uuid has a UUID set
6. Open Customize Panel again
7. Click "Reset to Default" in Wallpapers section to remove the custom wallpaper
8. Expected: In about:config, the pref browser.newtabpage.activity-stream.newtabWallpapers.customWallpaper.uuid should be blank (reset)
9. Actual: In about:config, the pref browser.newtabpage.activity-stream.newtabWallpapers.customWallpaper.uuid has a UUID set

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1955638 - Reset custom wallpaper UUID pref on reset r?#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99371e126333
Reset custom wallpaper UUID pref on reset r=home-newtab-reviewers,mconley

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/99371e126333

Comment 4

[Florin Bilt]

Perfherder has detected a talos performance change from push 99371e126333c10b0f1ca7eaa8cb62cd6d4f9da9.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
29%	offscreencanvas_webcodecs_main_webgl_vp9 offscreencanvas_webcodecs_main_webgl_vp9 Mean time across 100 frames:	windows11-64-shippable-qr	e10s fission stylo webrender	2.21 -> 1.57
28%	offscreencanvas_webcodecs_main_webgl_av1 offscreencanvas_webcodecs_main_av1_webgl Mean time across 100 frames:	windows11-64-shippable-qr	e10s fission stylo webrender	1.80 -> 1.29

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44506

For more information on performance sheriffing please see our FAQ.