1955643 - URL bar tab group matching only matches first word in tab group name

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Haik Aftandilian [:haik]]

Attachment: Screenshots showing "trav" matches the tab group "Travel Vacation Planning", but not "vacation" or "planning"

When typing a tab group name in the URL bar, a tab group only appears as a suggestion if the entered string is an exact match starting at the beginning of the group name. For example, for a group named "Travel Vacation Planning", typing a substring of name starting at "travel ..." does match, but substrings of the group name such as "vacation planning" do not match (see screenshot). Could the name matching would be more flexible? This might interfere with searching.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1955643 - Match across whole group names when typing more than one character. r?Daleharvey

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcf7c5cf33d4
Match across whole group names when typing more than one character. r=daleharvey

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fcf7c5cf33d4

Comment 6

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly 140.0a1 (2025-04-30)

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1955643 - Match across whole group names when typing more than one character. r=#release-managers

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1955643#c0
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: already verified
• Risk associated with taking this patch: Low
• Explanation of risk level: Trivial implementation, doing substring matching on group names when typing more than one character. We expect we can improve this further, but I deliberately went for the most simple fix here as an incremental improvement that should be easy to uplift.
• String changes made/needed: none
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/81c1cb887f37

Comment 10

[Dão Gottwald [:dao]]

Hey Rares, could you please verify this on Beta when you're back?

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 139.0b3

Comment 12

[Rares Doghi, Desktop QA]

Updating the remaining main status flag.