1955664 - `Open In New Tab` doesn't scroll for text fragments

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Sean Feng [:sefeng211]]

STR:

1. Open https://github.com/WICG/nav-speculation/issues/368
2. Right click the source link in the description with Open In New Tab

A new tab is opened, but Firefox doesn't scroll to the highlight. Chrome does scroll though.

This is 20250321040811 build on Linux

Comment 1

[Jan Jaeschke [:jjaschke]]

I can repro. This is only if the link is opened via the context menu, and also occurs for Open in New Window.

about:logging hints that the user involvement check is not working as expected.

Comment 2

[Jan Jaeschke [:jjaschke]]

Some more context after having a few offline discussions around this:

The immediate reason for not scrolling is that opening a link in a new tab / window first opens about:blank in the new tab/window, then navigates to the link from there. That means that the triggering principal, which is currently used to check for user involvement, is the null principal (instead of the system principal which one would expect, since the action was triggered from the context menu). Also, it seems that there is a difference between CTRL-Click on a link and Context Menu -> Open in a new Tab w.r.t. user activation (going through context menu = no user activation).

In order to fix this, we need to properly implement User Involvement -- which coincidentally we currently do in our Navigation API work (Bug 1777171 as meta).

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1955664 - Text Fragments: Propagate user activation correctly when opening a link in a new tab or window. r=gijs!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5998aa21cd9b
https://hg.mozilla.org/integration/autoland/rev/172b4f01ef69
Text Fragments: Propagate user activation correctly when opening a link in a new tab or window. r=Gijs

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/172b4f01ef69

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-08-12 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 144.0a1 and Firefox 143.0b2 on Windows 10, Ubuntu 22, macOS 15.