1955854 - style editor: pasting code via context menu duplicates code

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Sören Hentzschel]

STR:

1. Copy some code
2. Open the style editor
3. Use the context menu to paste the copied code

Actual:

The code is pasted twice.

Expected:

The code is pasted once.

Pasting via keyboard shorcut does not have this problem.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Style Editor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Tom Schuster (MoCo) | OOO back 1. Dec]

Attachment: Bug 1955854 - Only handle Style Editor specific commands. r?#devtools-reviewers,bomsy

Turns out my first version of D238048 was actually correct. We seem to
get "command" events even for events not defined in <commandset
id="sourceEditorCommands">.

Comment 3

[Tom Schuster (MoCo) | OOO back 1. Dec]

Thanks Sören for the report and the bisection.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb9e170001c4
Only handle Style Editor specific commands. r=devtools-reviewers,nchevobbe

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eb9e170001c4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tschuster, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Tom Schuster (MoCo) | OOO back 1. Dec]

Not sure if we need to uplift this, it doesn't seem super critical to me.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Tom Schuster from comment #7)

Not sure if we need to uplift this, it doesn't seem super critical to me.

that's a regression, potentially super annoying and since I was told uplift are cheap, we might do it. Tom can you request it please?

Comment 9

[Tom Schuster (MoCo) | OOO back 1. Dec]

Comment on attachment 9473928 [details]
Bug 1955854 - Only handle Style Editor specific commands. r?#devtools-reviewers,bomsy

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Pasting in the Style Editor is broken
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple patch
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/ec4aed242ef1