1955881 - [app icon picker] Create `adaptive-icon` xmls

Status: RESOLVED FIXED

(Firefox for Android :: Settings, task)

Description

[Mike a [:mavduevskiy]]

Create adaptive-icon xmls with added icons, backgrounds and using existing in main launcher monochrome icons.

Link to the final icon version: click

• Add both square icons and round icons (round icons were added in API 25), also we are using square versions for presenting icon options to the user;
• Verify with the UX that we are not using round versions there, since it’s a departure from the actual look for the majority of devices that use round icons;
• For consistency, consider tying the naming of the icons and aliases to the title names we will be using in the app icon picker screen. It might come in handy, especially if we experiment with promoting sets of icons, configuring nimbus parameters with a list of activity alias names.
• Icon requirements (from the spike)
  To set expectations about file sizes, here are some examples of icons from the app:
  Ic_launcher_foreground, release app icon, 11kb
  Ic_launcher_private_background, private mode icon gradient background, 884b
  Ic_extensions_onboarding, central image for addons onboarding card, 30kb
  Ic_notification_permission, central image for notification permissions, 129kb – biggest vector file we have
  ~10kb for simpler icons, ~50kb for more elaborate images, ~150kb exceptional

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1955881 - Part 1: Adding app icons with solid background for icon picker screen

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1955881 - Part 2: Adding app icons with gradient background for icon picker screen

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1955881 - Part 3: Adding app icons with alternative foreground for icon picker screen

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c973ae68a90c
Part 1: Adding app icons with solid background for icon picker screen r=android-reviewers,gmalekpour,twhite
https://hg.mozilla.org/integration/autoland/rev/afdc96441697
Part 2: Adding app icons with gradient background for icon picker screen r=android-reviewers,gmalekpour,twhite
https://hg.mozilla.org/integration/autoland/rev/cda489dfe14a
Part 3: Adding app icons with alternative foreground for icon picker screen r=android-reviewers,gmalekpour,twhite

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing fenix build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/4b373fe060fb3e80baeb7471fb6085450238df28

Push with failures

Failure log -> ERROR: /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/res/mipmap-anydpi-v26/ic_launcher_solid_dark.xml:8: AAPT: error: resource color/ic_launcher_solid_dark_background

FAILURE: Build failed with an exception.
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] * What went wrong:
[task 2025-04-15T04:07:17.428Z] Execution failed for task ':app:processFenixBenchmarkResources'.
[task 2025-04-15T04:07:17.428Z] > A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
[task 2025-04-15T04:07:17.428Z]    > Android resource linking failed
[task 2025-04-15T04:07:17.428Z]      ERROR: /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/res/mipmap-anydpi-v26/ic_launcher_solid_dark.xml:8: AAPT: error: resource color/ic_launcher_solid_dark_background (aka org.mozilla.fenix:color/ic_launcher_solid_dark_background) not found.
[task 2025-04-15T04:07:17.428Z]          
[task 2025-04-15T04:07:17.428Z]      ERROR: /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/res/mipmap-anydpi-v26/ic_launcher_solid_light.xml:8: AAPT: error: resource color/ic_launcher_solid_light_background (aka org.mozilla.fenix:color/ic_launcher_solid_light_background) not found.
[task 2025-04-15T04:07:17.428Z]          
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] * Try:
[task 2025-04-15T04:07:17.428Z] > Run with --stacktrace option to get the stack trace.
[task 2025-04-15T04:07:17.428Z] > Run with --info or --debug option to get more log output.
[task 2025-04-15T04:07:17.428Z] > Run with --scan to get full insights.
[task 2025-04-15T04:07:17.428Z] > Get more help at https://help.gradle.org.
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] For more on this, please refer to https://docs.gradle.org/8.13/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
[task 2025-04-15T04:07:17.428Z] 
[task 2025-04-15T04:07:17.428Z] BUILD FAILED in 8m 17s

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c122809bd135
Part 1: Adding app icons with solid background for icon picker screen r=android-reviewers,gmalekpour,twhite
https://hg.mozilla.org/integration/autoland/rev/4c5c949773ff
Part 2: Adding app icons with gradient background for icon picker screen r=android-reviewers,gmalekpour,twhite
https://hg.mozilla.org/integration/autoland/rev/f3f64220738e
Part 3: Adding app icons with alternative foreground for icon picker screen r=android-reviewers,gmalekpour,twhite

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c122809bd135
https://hg.mozilla.org/mozilla-central/rev/4c5c949773ff
https://hg.mozilla.org/mozilla-central/rev/f3f64220738e