1955887 - [app icon picker] Add app icon selection middleware

Status: REOPENED

(Firefox for Android :: Settings, task)

Description

[Mike a [:mavduevskiy]]

Add app icon selection middleware handling side effects for icon selection

• NB: When processing AppIconSelected, the icon change might result in error and we should make sure that the repository is updated to the actual state.
• Should confirm with the UX the expected behaviour: should we shut down the app right away or launch a warning dialog here?

Comment 1

[Mike a [:mavduevskiy]]

decided to simplify the architecture of the component, and to go without middleware/stores

Comment 2

[Mike a [:mavduevskiy]]

the UI got more complicated, and there is need for store/reduces/middleware

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1955887 - Part 1: Introduce a data layer to the app icon selector feature

Comment 4

[Mike a [:mavduevskiy]]

Attachment: Bug 1955887 - Part 2: Add an error snackbar in case changing the icon failed

Comment 5

[Mike a [:mavduevskiy]]

Attachment: Bug 1955887 - Part 3: Preserve store state during configuration change

... while avoiding memory leaks.

Comment 6

[Mike a [:mavduevskiy]]

Attachment: Bug 1955887 - Part 4: Report app icon change failures to sentry

Comment 7

[Mike a [:mavduevskiy]]

Attachment: Bug 1955887 - Part 5: Refactor app icon state to have a separate warning state member