1955911 - Use correct pixel format for exported dmabuf surfaces [FEATURE_DMABUF_SURFACE_EXPORT]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

If Linux/HDR rendering is used, we need to clear framebuffer of WebGL. Shared&recycled surfaces are used for framebuffer so it contains content of previous frames.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Happens if FEATURE_DMABUF_SURFACE_EXPORT is used only.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Looks like working in KDE, broken in Mutter only.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Doesn't look to be a problem with simple frame buffer clear. If I disable surface recycling and clear dmabuf surfaces before use, there is still transparent/missing background. Produces different results with alpha set.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Looks like we use the exported surfaces wrongly. We need to keep the GL context and textures/EGLImages as far as we use the memory. Looks like MESA releases it and reuses it after it.

Right now we use GBM model where we create/delete textures/EGLImages if we don't need it and keep reference to dmabuf by file descriptors, which is insufficient for exported dmabuf surfaces.

That also means we can't pass such surfaces between processes freely - we'd need to keep original texture/EGLImage as far as it's used by parent process.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

More investigation reveals we create GBM buffers as transparent while exported ones are marked as opaque so we don't paint underlying layer and we see the artifacts here.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1955911 [Linux] Get correct DRM surface format for dmabuf surfaces created by EGL_MESA_image_dma_buf_export r?emilio

• Translate DRM formats to gfx::SurfaceFormat.
• Update DMABufSurface::HasAlpha() for different drm formats.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1955911 [Linux] Don't create DMABufSurface with unsupported DRM format r?emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b87c7308511
[Linux] Get correct DRM surface format for dmabuf surfaces created by EGL_MESA_image_dma_buf_export r=emilio
https://hg.mozilla.org/integration/autoland/rev/1cc6a56b71a1
[Linux] Don't create DMABufSurface with unsupported DRM format r=emilio

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7b87c7308511
https://hg.mozilla.org/mozilla-central/rev/1cc6a56b71a1