1955990 - Show data collection permissions in `about:addons`

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

This is about showing the new data collection permissions in about:addons.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1955990 - Show data collection permissions in `about:addons`. r?rpl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14907364ca3
Show data collection permissions in `about:addons`. r=rpl,fluent-reviewers,desktop-theme-reviewers,bolsson,Itiel

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_parsable_css.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property --green-60 is not referenced -

Comment 4

[William Durand [:willdurand]]

I see. about:addons was the only consumer of the --green-60 CSS variable defined in https://searchfox.org/mozilla-central/rev/08b2a1a770688df19a5a43fd89fb63b34bb2d6a6/toolkit/themes/shared/in-content/common-shared.css#68, which is removed in the patch I've attempted to land. That's why browser_parsable_css.js complained. I updated the patch to remove this CSS variable.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6541995f1daf
Show data collection permissions in `about:addons`. r=rpl,fluent-reviewers,desktop-theme-reviewers,bolsson,Itiel

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6541995f1daf

Comment 7

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (139.0a1/20250427085921) under Windows 11 and Ubuntu 24.04 LTS.

For an extension requiring data collection, the permissions tab in about:addons will show a
“Required data collection:” header, followed underneath by a string stating “The developer says this extension collects: <data_type_1>, <data_type_2>, etc.”.

For an extension with optional data collection requesting the T&I optional data collection permission, the permissions tab in about:addons will show a “Optional data collection:” header, followed underneath by a toggle (enabled by default) and a string stating “Share technical and interaction data with extension developer”.

For an extension with optional data collection requesting a permission other than T&I, the permissions tab in about:addons will show a “Optional data collection:” header, followed underneath by a toggle (disabled by default) and a string stating “Share <data_type_1>, <data_type_2> etc. with extension developer”.

For an extension with no data collection, the permissions tab in about:addons will show a
“Required data collection:” header, followed underneath by a string stating “The developer says this extension doesn’t require data collection.”

For an extension with both the “none” data type and another data type, the permissions tab in about:addons will show a “Required data collection:” header, followed underneath by a string stating “The developer says this extension collects: <data_type_1>, <data_type_2>, etc.”.