Closed
Bug 195607
Opened 22 years ago
Closed 22 years ago
Minimum width code gets it wrong
Categories
(Bugzilla :: Reporting/Charting, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file)
|
706 bytes,
patch
|
bugreport
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
The "minimum width" code for bar charts has two problems.
1) The minimum is too small. Either preed or joel pointed this out before, but I
refused to believe them :-) Dunno what happened there. Anyway, it is.
2) It adjusts the width unconditionally (i.e. even when we are using the
default, and $width is undefined), so bar charts are thinner than they should be
a lot of the time.
Patch coming.
Gerv
|
Assignee | |
Comment 1•22 years ago
|
||
Fixes problem. Either of you gentlemen want to rubber-stamp this, or am I going
to have to formally request review? :-)
Gerv
|
|
Assignee | |
Updated•22 years ago
|
Attachment #116019 -
Flags: review?(bugreport)
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 116019 [details] [diff] [review]
Patch v.1
Dave: more min_width issues :-)
Gerv
Attachment #116019 -
Flags: review?(justdave)
|
||
Updated•22 years ago
|
Attachment #116019 -
Flags: review?(bugreport) → review+
|
|
Assignee | |
Updated•22 years ago
|
Flags: approval?
|
||
Updated•22 years ago
|
Attachment #116019 -
Flags: review?(justdave)
|
|
||
Updated•22 years ago
|
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 3•22 years ago
|
||
Fixed.
Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v <-- report.cgi
new revision: 1.16; previous revision: 1.15
done
Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•