Closed Bug 195621 Opened 21 years ago Closed 21 years ago

Back out taint-related changes from bug 160710

Categories

(Bugzilla :: User Accounts, defect)

Product:
Bugzilla
Component:
User Accounts
Version:
2.17.3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

Patch v.1
1.25 KB, patch
justdave
: review+
Details | Diff | Splinter Review 
In bug 160710 we changed the nice:
-  [% PROCESS "account/prefs/${current_tab.name}.html.tmpl" IF
current_tab.name.defined %]

to a nasty hard-coded switch-like thing, for perl 5.005 taint reasons. Now we
are 5.6 only, we can restore the old code.

Gerv
Attached patch Patch v.1 — — Splinter Review 
Here we are.

Gerv
Attachment #116026 - Flags: review?(bbaetz)
Does this work with 5.6.0? That still had some of the bugs relating to this.
Er... I dunno :-) Who still uses 5.6.0 that we can get to test it?

Gerv
The jdr200 tinderbox machine has 5.6.0 on it still.  I can try it there.

Anyone with OSX, ie justdave :)
Dave: are you going to be able to test this?

Gerv
Attachment #116026 - Flags: review?(justdave)
Comment on attachment 116026 [details] [diff] [review]
Patch v.1

works on 5.6.0 osx
Attachment #116026 - Flags: review?(justdave)
Attachment #116026 - Flags: review?(bbaetz)
Attachment #116026 - Flags: review+
Flags: approval+
Fixed.

Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v
 <--  prefs.html.tmpl
new revision: 1.10; previous revision: 1.9
done

Gerv
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.