195621 - Back out taint-related changes from bug 160710

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Gervase Markham [:gerv]]

In bug 160710 we changed the nice:
-  [% PROCESS "account/prefs/${current_tab.name}.html.tmpl" IF
current_tab.name.defined %]

to a nasty hard-coded switch-like thing, for perl 5.005 taint reasons. Now we
are 5.6 only, we can restore the old code.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here we are.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Does this work with 5.6.0? That still had some of the bugs relating to this.

Comment 3

[Gervase Markham [:gerv]]

Er... I dunno :-) Who still uses 5.6.0 that we can get to test it?

Gerv

Comment 4

[Dave Miller [:justdave]]

The jdr200 tinderbox machine has 5.6.0 on it still.  I can try it there.

Comment 5

[Bradley Baetz (:bbaetz)]

Anyone with OSX, ie justdave :)

Comment 6

[Gervase Markham [:gerv]]

Dave: are you going to be able to test this?

Gerv

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 116026 [details] [diff] [review]
Patch v.1

works on 5.6.0 osx

Comment 8

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v
 <--  prefs.html.tmpl
new revision: 1.10; previous revision: 1.9
done

Gerv