1956215 - The Manage Settings Option from the Callout 3 does not redirect the user to the correct option in about:preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Rares Doghi, Desktop QA]

Found in

• Nightly 138.0a1 (2023-08-25)

Affected versions

• Nightly 138.0a1 (2023-08-25)

Affected platforms

• All

Preconditions:
Have RC in the Sidebar.

Steps to reproduce

1. Open the Review Checker in the Firefox Sidebar but do not optin.
2. Close the Sidebar and Close the Firefox browser.
3. Advance Time for 24 hours.
4. Reach a product details page.
5. Expand the Dismiss options dropdown from the RC callout.
6. Click the Manage Settings option.

Expected result

• The user should be redirected to the "Recommend features as you browse" option in about:preferences.

Actual result

• The user is redirected to the beginning of the about:preferences page.

Regression range
Not Applicable

Comment 1

[Emily McMinn :emcminn]

Looks like this is a more general issue with the preferences page being linked to from the split dismiss button. We're seeing it on other messages as well. about:preferences#general-cfrfeatures doesn't work in nightly but works in release.

Comment 2

[Shane Hughes [:aminomancer]]

mozregression narrowed it to this pushlist. Based on reading the code, I believe this was regressed by bug 1951141. It seems that our items are created without a data-subcategory. This is apparently because it's setting subcategory and not data-subcategory, which is what the function uses to scroll and highlight.

This looks like an easy fix, but before changing it to data-subcategory let's ask Mark if there's anything relying on it being subcategory.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1951141

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1956215 - fix data-subcategory for cfrfeatures and other setting groups, r?Gijs

Comment 5

[:Gijs (he/him)]

(In reply to Shane Hughes [:aminomancer] from comment #2)

This looks like an easy fix, but before changing it to data-subcategory let's ask Mark if there's anything relying on it being subcategory.

Yeah I'm fairly sure this was just an oversight.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7a9ef53b8df
fix data-subcategory for cfrfeatures and other setting groups, r=settings-reviewers,Gijs

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a7a9ef53b8df

Comment 8

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 139.0a1 (2025-04-04)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[:Gijs (he/him)]

Attachment: Bug 1956215 - fix data-subcategory for cfrfeatures and other setting groups, r?Gijs

Original Revision: https://phabricator.services.mozilla.com/D244375

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Broken review checker callout links
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: minor changes to how only a small part of prefs is generated, plus a more general change to how we scroll the prefs
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/18b8e94957ce

Comment 13

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 138.0b4