1956345 - Add MVP support for co-located Jujutsu/`jj` to `moz-phab`

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement, P1)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1956345 - detect Jujutsu repos, don't do anything useful yet r=sheehan

Co-Authored-By: Malte Jürgens <[e-mail]>

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1956345 - feat: support `moz-phab submit` for co-located Jujutsu repos r=sheehan

Co-Authored-By: Malte Jürgens <[e-mail]>

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1956345 - feat: support `moz-phab patch` for co-located Jujutsu repos r=sheehan

Co-Authored-By: Malte Jürgens <[e-mail]>

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

:sheehan: Some outstanding known issues for Jujutsu support in the current patch stack are listed here: erichdongubler-mozilla/review#1

I'm happy to turn these into Bugzilla entries once the patch stack has been accepted, assuming they're not blockers for landing. 🙂

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1956345 - test: normalize `test_helpers.py` formatting with `black` r=sheehan

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1956345 - refactor: accept any positional and keyword args. in `probe_repo` test stubs r=sheehan

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

:sheehan, are you able to give this review some attention soon? I see some chatter in bug 1929372, comment 17 indicating a desire to see the patch stack for this and bug 1964150 landed.

Comment 8

[Connor Sheehan [:sheehan]]

(In reply to Erich Gubler [:ErichDonGubler] (he/him) from comment #7)

:sheehan, are you able to give this review some attention soon? I see some chatter in bug 1929372, comment 17 indicating a desire to see the patch stack for this and bug 1964150 landed.

Sorry for the delay here. I will land the patches and handle adding jj to our CI infra in bug 1975241.

Comment 9

[BMO Github Automation]

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/a7ecc0d6ed0b15d9e1c40caf0725b9c8d7eb3082
[main] Bug 1956345 - test: normalize test_helpers.py formatting with black r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/5be362dc989eff303503187ca58acb8549a53405
[main] Bug 1956345 - refactor: accept any positional and keyword args. in probe_repo test stubs r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/3bf958a7d291c7dcbc1021ce59f0980fee52ba4d
[main] Bug 1956345 - detect Jujutsu repos, don't do anything useful yet r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/4139112b9079aad03b1f71d324e77a9a1ffddbec
[main] Bug 1956345 - feat: support moz-phab submit for co-located Jujutsu repos r=sheehan

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/7aca92ae390205d5d104fb25a283d33846444b89
[main] Bug 1956345 - feat: support moz-phab patch for co-located Jujutsu repos r=sheehan

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

Woot!