Tidy up about dialog page in cZ
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
13.72 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment the whole of the client object is passed to the about dialog page and it loads various JS files just to work out the list of localisers, the user agent and the version string. Most of this information has already been worked out, so let's just add the list of localisers and only pass the information needed.
Whilst here also tidy up how the version number is passed around - add version property to the client object.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: two removals, one addition
Updated•7 months ago
|
Comment 2•7 months ago
|
||
Comment on attachment 9474536 [details] [diff] [review]
1956376-irc-about-25321.patch
LGTM r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/65b488cf9e33
Tidy up about dialog page in cZ. r=frg DONTBUILD
Comment 4•2 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/48255cec4f5247a2f47fddf1ca4f6577160985b1
Tidy up about dialog page in cZ. r=frg a=frg
Description
•