Closed Bug 1956376 Opened 8 months ago Closed 7 months ago

Tidy up about dialog page in cZ

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

At the moment the whole of the client object is passed to the about dialog page and it loads various JS files just to work out the list of localisers, the user agent and the version string. Most of this information has already been worked out, so let's just add the list of localisers and only pass the information needed.
Whilst here also tidy up how the version number is passed around - add version property to the client object.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: two removals, one addition

Attachment #9474536 - Flags: review?(frgrahl)
Attachment #9474536 - Flags: approval-comm-release?
Whiteboard: SM2.53.21

Comment on attachment 9474536 [details] [diff] [review]
1956376-irc-about-25321.patch

LGTM r/a+

Attachment #9474536 - Flags: review?(frgrahl)
Attachment #9474536 - Flags: review+
Attachment #9474536 - Flags: approval-comm-release?
Attachment #9474536 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/65b488cf9e33
Tidy up about dialog page in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: