Closed
Bug 1956377
Opened 5 months ago
Closed 4 months ago
Add helper to commands.js for sending CTCP commands in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
2.50 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
There's some code duplication across cmdPing, cmdVersion and cmdTime. Let's add a small helper to remove the duplication.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9474537 -
Flags: review?(frgrahl)
Attachment #9474537 -
Flags: approval-comm-release?
![]() |
||
Updated•4 months ago
|
![]() |
||
Comment 2•4 months ago
|
||
Comment on attachment 9474537 [details] [diff] [review]
1956377-irc-send-ctcp-25321.patch
LGTM r/a+
Attachment #9474537 -
Flags: review?(frgrahl)
Attachment #9474537 -
Flags: review+
Attachment #9474537 -
Flags: approval-comm-release?
Attachment #9474537 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/12de9adfc2f1
Add helper to commands.js for sending CTCP commands in cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•