1956488 - Add sections to the add-on prompts

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[William Durand [:willdurand]]

Attachment: Screenshot 2025-03-26 at 13.36.36.png

This bug is about updating the install prompt to introduce different sections for required permissions, data collection, and other optional settings. Per UX:

• Add 3 bold headlines to all install dialogs (Required permissions, Data collection, Optional settings)
• Add 2 bold headlines to all update dialogs (New required permissions, New required data collection)
• Add intro copy to all update modals AND update headline on all update modals (this essentially splits the current title into a title and a short paragraph in the popup content)
• Update headline on all install dialogs to "Add [extension name]"
• Add 2 bold headlines to optional dialogs asking for new permissions and new data collection (New permissions, New data collection)

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1956488 - Add sections to the add-on install/update/optional prompts. r?rpl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/087fb47c190a
Add sections to the add-on install/update/optional prompts. r=rpl,fluent-reviewers,desktop-theme-reviewers,dao,bolsson

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/087fb47c190a

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1956488 - Port Bug 1956488 - Add sections to the add-on install/update/optional prompts. r=john.bieling

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/203c98f3afc9
Port Bug 1956488 - Add sections to the add-on install/update/optional prompts. r=john.bieling

Comment 6

[Phabricator Automation]

Comment on attachment 9485937 [details]
Bug 1956488 - Port Bug 1956488 - Add sections to the add-on install/update/optional prompts. r=john.bieling

Revision D248182 was moved to bug 1964904. Setting attachment 9485937 [details] to obsolete.

Comment 7

[Alex Cornestean]

Tested on the latest Nightly (140.0a1/20250507164202) under Windows 11 and Ubuntu 24.04 LTS.

The install dialog now contains three bold headlines for “Required permissions”, “Data collection” and “Optional settings” and the topmost headline now states “Add [extension_name]”. See attached screenshot.

The update dialog now contains two bold headlines for “New required permissions” and “New required data collection”. The title has been updated to “[extension_name] requires new settings to update and is followed by a paragraph stating “Cancel to keep your current version and settings, or update to get the new version and approve the changes.” See attached screenshot.

The optional permissions request dialog now contains a bold headline for “New permissions”. See attached screenshot.

Although I managed to verify most of what was mentioned in Comment 0, I did not find or managed to create an extension with an optional dialog asking for data collection so I’m asking for a bit of help with this.
I’ll set the bug to Verified once I also manage to check the optional dialog for data collection.

Comment 8

[Alex Cornestean]

Attachment: 2025-05-08_11h40_56.png

Comment 9

[Alex Cornestean]

Attachment: 2025-05-08_11h40_21.png

Comment 10

[Alex Cornestean]

Attachment: 2025-05-08_11h44_48.png

Comment 11

[William Durand [:willdurand]]

(In reply to Alex Cornestean from comment #7)

Although I managed to verify most of what was mentioned in Comment 0, I did not find or managed to create an extension with an optional dialog asking for data collection so I’m asking for a bit of help with this.
I’ll set the bug to Verified once I also manage to check the optional dialog for data collection.

This can be achieved using https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/permissions/request, passing { data_collection: ["locationInfo"] } to it for instance.

Comment 12

[Alex Cornestean]

The optional data collection permissions request dialog’s title states “[extension_name] requests additional data collection” and the dialog contains a bold headline for “New data collection”, followed by a string stating ”The developer says the extension wants to collect: [data_type]”.

See attached screenshot for more details.

Tested on the latest Nightly (141.0a1/20250602211130) and Beta (140.0b4/20250602090557) under Windows 11 and Ubuntu 24.04 LTS.

Since I verified the last piece, I’ll be closing this bug as Verified Fixed.

Comment 13

[Alex Cornestean]

Attachment: 2025-06-03_16h14_09.png