1956578 - [css-sizing] Resolved value of min size properties doesn't round-trip

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#11716.

[css-sizing] Resolved value of min size properties doesn't round-trip

• RESOLVED: When aspect-ratio is non-initial, then min-size:auto serializes as 'auto' in gCS() (rather than being censored to 0)

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1956578: Preserve the min-width/min-height 'auto' value in getComputedStyle, for elements with non-default 'aspect-ratio'. r?#style,#layout

This is the behavior that was resolved on in
https://github.com/w3c/csswg-drafts/issues/11716

I'm including a WPT that exercises a bunch of different cases where 'auto' is
or isn't preserved in getComputedStyle.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b9e820b1f3d
Preserve the min-width/min-height 'auto' value in getComputedStyle, for elements with non-default 'aspect-ratio'. r=TYLin

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6b9e820b1f3d

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51748 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: Bug 1956578 followup: remove diagnostic logging that inadvertently got folded into main patch. (no review)

Comment 7

[Daniel Holbert [:dholbert]]

Per bug 1957570, I accidentally folded in some debug logging when doing hg amend --commit to fix a typo just before landing.

I just posted and triggered autoland on a followup patch to remove that logging.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/730840116285
followup: remove diagnostic logging that inadvertently got folded into main patch. (no review)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8709233e47fc
followup: remove diagnostic logging that inadvertently got folded into main patch. (no review) DONTBUILD

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/730840116285

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)