1956780 - Add strict weak ordering checks from newer libc++ to nsTArray

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

Moving from bug 1947516.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1956780 - Make nsHttpHandler::EchConfigEnabled a static function. r=#necko-reviewers

It doesn't need to be an instance function, and the new checks can cause
some comparators to be called where they weren't before, causing debug
assertions like the ones in bug 1947516 comment 13.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1956780 - Add strict weak ordering checks from newer libc++ to nsTArray. r=#xpcom-reviewers

This is a useful check that has caught real issues. Make sure our fuzzers and
automation hits it on non-libc++ based platforms too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/931a44705ab3
Make nsHttpHandler::EchConfigEnabled a static function. r=necko-reviewers,kershaw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5355d6f36636
Add strict weak ordering checks from newer libc++ to nsTArray. r=xpcom-reviewers,nika

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/931a44705ab3

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5355d6f36636