1956817 - Storybook launch should enable layout.forms.input-type-search and .reveal-password-button prefs

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

Since we are planning on enabling the "clear search" button on search inputs in privileged documents (Bug 1956634), we should enable the following prefs when launching Storybook:

• layout.forms.input-type-search.enabled
• layout.forms.reveal-password-button.enabled

Otherwise the moz-input-search component may appear broken/not in spec due to the missing clear search button. This won't fix our deployed Storybook unfortunately, as it is not a privileged document. We'll need to figure that out somewhere else.

See Bug 1804162 for prior art about setting a pref value for Storybook.

Comment 1

[Mark Striemer [:mstriemer]]

Bug 1981571 should touch the same places and could be easy enough to do both one after the other (or even together)

Comment 2

[Kipchumba Chelilim [:mrchumbastic]]

I can work on this bug!

Comment 3

[Kipchumba Chelilim [:mrchumbastic]]

Attachment: Bug 1956817 - Enable clear search button and reveal password preferences when launching storybook r=tgiles!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22e9e38b1ca3
https://hg.mozilla.org/integration/autoland/rev/df6d23fd3cd5
Enable clear search button and reveal password preferences when launching storybook r=tgiles

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/df6d23fd3cd5