1956870 - Adding `gradlew lint` to `android-{fenix|focus|ac}` linters and reporting lint errors on phabricator

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, enhancement)

Comment 1

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 1956870 - Increase scope of `android-lint` linter to run gradlew lint on all mobile projects and report errors on phabricator.

Currently CI runs android lint for android projects, but for developers to run lint locally they need to cd into the subdirectory and run gradlew lint. This bug adds gradlew lint to mach lint through the android-{fenix|focus|ac} linters in addition of ktlint and detekt which were added in [[ https://phabricator.services.mozilla.com/D216999 | D216999 ]]

This patch changes android lint configuration to generate JSON report of errors and then reads these errors in lints.py to report in the same format as other linters.

Comment 2

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1956870 - Adding `gradlew lint` to `android-{fenix|focus|ac}` linters and reporting lint errors on phabricator.

Currently CI runs android lint for android projects, but for developers to run lint locally they need to cd into the subdirectory and run gradlew lint. This bug adds gradlew lint to mach lint through the android-{fenix|focus|ac} linters in addition of ktlint and detekt which were added in [[ https://phabricator.services.mozilla.com/D216999 | D216999 ]]

This patch changes android lint configuration to generate JSON report of errors and then reads these errors in lints.py to report in the same format as other linters.

Comment 3

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 1956870 - Run detekt and ktlint in fenix and focus from root directory.

Comment 4

[Aaditya Dhingra [:adhingra]]

Attachment: WIP: Bug 1956870 - Move detekt and ktlint to root directory.

Comment 5

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1956870 - Fix lint errors reported by new linter.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39504fa76230
Adding `gradlew lint` to `android-{fenix|focus|ac}` linters and reporting lint errors on phabricator. r=android-reviewers,nalexander

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/39504fa76230