1956878 - Replace "about:home" with "Homepage" title in the tabs tray

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Image from iOS.jpg

When Homepage as a new Tab is enabled, homepage tabs have an URL of "about:home". In the tabs tray, we want to rename "about:home" that will appear as the title to "Homepage".

The task is to the following:

• Add a Globe placeholder icon next to the displayed title for "about:home" tabs. This would appear in-place of a favicon that would be loaded using the page URL or a loaded page icon as defined by tab.content.icon, which wouldn't happen for an "about:home" url.
• In the tabs tray, the displayed title of a tab comes from tab.toDisplayTitle() which reads the tab.content.title. To replace "about:home" with the desired "Homepage" display title, we want to set tab.content.title to "Homepage" when the homepage tab is created.

Figma: https://www.figma.com/design/HWTT1sbVrKtD2gxX3IzAM7/Home?node-id=4253-24499&t=PQqlLAF50L1tiNNy-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1956878 - Part 1: Center the tab display title in TabGridItem

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb2b67259885
Part 1: Center the tab display title in TabGridItem r=android-reviewers,007

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1956878 - Part 2: Refactor adding a new homepage tab into a use case in FenixBrowserUseCases

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1956878 - Part 3: Add a "Homepage" title for "about:home" homepage tabs

• Adds a title parameter to specify the title to be used in the add new tab use case in TabsUseCases.
• Use "Homepage" as the title for "about:home" homepage tabs when created in the FenixBrowserUseCases.
• "Homepage" will be the displayed title for Homepage tabs in the tabs tray.
• Figma: https://www.figma.com/design/HWTT1sbVrKtD2gxX3IzAM7/Home?node-id=4253-24499&t=PQqlLAF50L1tiNNy-4

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1956878 - Part 4: Display a Globe placeholder icon when a page icon is not available in `TabGridItem`

• Display a Globe placeholder icon for "about:home" homepage tabs that will not have a page icon.
• Figma: https://www.figma.com/design/HWTT1sbVrKtD2gxX3IzAM7/Home?node-id=4253-24499&t=PQqlLAF50L1tiNNy-4
• The Figma depicts that a Firefox icon should be displayed for Homepage tabs, but iOS is currently using a Globe icon. We will defer to using the Globe icon for now.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bb2b67259885

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dc5d8e4ffd5
Part 2: Refactor adding a new homepage tab into a use case in FenixBrowserUseCases r=devota,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/b68c35a207b6
Part 3: Add a "Homepage" title for "about:home" homepage tabs r=devota,android-reviewers,android-l10n-reviewers,delphine

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing Android Components opt build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | mozilla.components.feature.serviceworker.ServiceWorkerSupportTest.GIVEN service worker support is installed WHEN runtime is called to open a new window THEN do so and return a new EngineSession | org.mockito.exceptions.misusing.InvalidUseOfMatchersException:

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6167c9bcb52c
Part 2: Refactor adding a new homepage tab into a use case in FenixBrowserUseCases r=devota,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/2583d784a067
Part 3: Add a "Homepage" title for "about:home" homepage tabs r=devota,android-reviewers,android-l10n-reviewers,delphine

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6167c9bcb52c
https://hg.mozilla.org/mozilla-central/rev/2583d784a067

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bb884927bca
Part 4: Display a Globe placeholder icon when a page icon is not available in `TabGridItem` r=007,android-reviewers

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2bb884927bca