1956918 - "Calendar.cpp:1414:27: error: result of comparison of 15 >= 4-bit unsigned value is always true" with NDK r29-beta1

Status: VERIFIED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I ran a Try push with NDK r29-beta1 and hit the following build failure:
https://treeherder.mozilla.org/logviewer?job_id=501319338&repo=try&lineNumber=12433

 INFO -  In file included from Unified_cpp_builtin_temporal0.cpp:2:
ERROR -  /builds/worker/checkouts/gecko/js/src/builtin/temporal/Calendar.cpp:1414:27: error: result of comparison of 15 >= 4-bit unsigned value is always true [-Werror,-Wtautological-value-range-compare]
 INFO -   1414 |   static_assert(MaxLength >= ICUEraNameMaxLength(),
 INFO -        |                 ~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~
 INFO -  1 error generated.

Andre, can you please take a look when you get a chance? I've attached a WIP patch to the dependent bug which should allow for easier testing on Try.

Comment 1

[André Bargull [:anba]]

We've previously seen the same issue for wasm32-wasi (bug 1936626). It's strange that there isn't an error for other configurations...

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1956918: Disable tautological-value-range-compare to avoid a bogus Clang warning. r=dminor!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8506de501886
Disable tautological-value-range-compare to avoid a bogus Clang warning. r=dminor

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8506de501886

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Looks good, thanks!