1956996 - Don't pass VA-API decoded frames with unsupported modifiers as wl_buffers

Status: RESOLVED INCOMPLETE

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Checked with latest build (mercurial clone) - with wayfire shows OK (previously was shadow only) but crash immediately after startin VAAPi play on youtube

RDD 35911: MediaPDecoder #1]: D/Dmabuf VideoFrameSurface: creating surface UID 36
[RDD 35911: MediaPDecoder #1]: D/Dmabuf Using VA-API DMABufSurface UID 36 FFMPEG ID 0x4
[RDD 35911: MediaPDecoder #1]: D/Dmabuf Used HW surface UID 16 FFMPEG ID 0x3
[RDD 35911: MediaPDecoder #1]: D/Dmabuf Surface pool size 5 used copied 3 used ffmpeg 1 (max 0) free ratio -inf
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::UpdateYUVData() UID 36 copy 1
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600] DMABufSurfaceYUV::CreateYUVSurface() UID 37 from desc
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::UpdateYUVData() UID 37 copy 0
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::ImportPRIMESurfaceDescriptor() UID 37 FOURCC 3231564e
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: plane 0 size 1280 x 720 format 20203852
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: plane 1 size 640 x 360 format 38385247
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::ImportPRIMESurfaceDescriptor() UID 36 FOURCC 3231564e
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: plane 0 size 1280 x 720 format 20203852
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: plane 1 size 640 x 360 format 38385247
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::CreateTexture() UID 37 plane 0
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::CreateYUVPlaneExport() UID 36 size 1280 x 720 plane 0
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: imported size 1280 x 720 format 3231564e planes 2 modifiers 0
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::CreateTexture() UID 37 plane 1
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::CreateYUVPlaneExport() UID 36 size 640 x 360 plane 1
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: imported size 640 x 360 format 3231564e planes 2 modifiers 100000000000009
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::ReleaseTextures() UID 37
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::ReleaseTextures() UID 36
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::ReleaseSurface() UID 37
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurfaceYUV::ReleaseTextures() UID 37
[RDD 35911: MediaPDecoder #1]: D/Dmabuf [7f5127633600]: DMABufSurface::ReleaseDMABuf() UID 37
[RDD 35911: MediaPDecoder #1]: D/Dmabuf DMABUFSurfaceImage::DMABUFSurfaceImage (7f51263de100) aSurface 7f5127634d90 UID 36
[RDD 35911: MediaSupervisor #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::Serialize() UID 36
[RDD 35911: MediaSupervisor #1]: D/Dmabuf [7f5127634d90]: DMABufSurfaceYUV::Serialize() UID 36
Crash Annotation GraphicsCriticalError: |[0]CP+[GFX1-]: DMABufSurface::UseDmaBufExportExtension(): MESA_image_dma_buf import/export extensions! (t=33.9335) |[1][GFX1-]: () Wayland protocol error: zwp_linux_buffer_params_v1#362: error 4: sent modifier 72057594037927945 for plane 1, expected modifier 0 like other planes
(t=34.1035) [GFX1-]: () Wayland protocol error: zwp_linux_buffer_params_v1#362: error 4: sent modifier 72057594037927945 for plane 1, expected modifier 0 like other planes

Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Segmentation fault (core dumped)

Comment 1

[Martin Stránský [:stransky] (ni? me)]

We failed to use MESA_image_dma_buf import/export so we failed to create dmabuf. Is that NVIDIA hardware?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The log is incomplete, can't do anything here.