1957214 - Remove comment that is no longer accurate from Prompter.sys.mjs

Status: RESOLVED FIXED

(Toolkit :: Content Prompts, task)

Description

[Gregory Pappas [:gregp]]

Prompter.sys.mjs used to create a temporary object (PromptUtilsTemp) that extended PromptUtils.

var PromptUtilsTemp = {
    ...some extra utility methods
};
Object.setPrototypeOf(PromptUtilsTemp, PromptUtils);

Then PromptUtils would be reassigned to this object.

PromptUtils = PromptUtilsTemp;

This mess was cleaned up in bug 1808172, so this comment is no longer accurate.

// This is redefined below, for strange and unfortunate reasons.
import { PromptUtils } from "resource://gre/modules/PromptUtils.sys.mjs";

To reduce confusion, the comment should be removed.

Comment 1

[Gregory Pappas [:gregp]]

• toolkit/components/prompts/src/Prompter.sys.mjs#7

Comment 2

[Mason Abbruzzese]

Hey, I'm new and will submit a patch for this soon

Comment 3

[Mason Abbruzzese]

Attachment: Bug 1957214 - Remove inaccurate comment. r?mtigley!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mason, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Stephanie Cunnane [:scunnane]]

I have just landed this on Mason's behalf.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8df97b9e04f8
https://hg.mozilla.org/integration/autoland/rev/78c096b0950c
Remove inaccurate comment. r=mtigley DONTBUILD

Comment 7

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/78c096b0950c