1957280 - the scroll on the add bookmark dialog is very sensitive

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Seth]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

1. ctrl + d or clicking star (bookmark this page) button
2. clicking the expand button under location to show all bookmarks folders
3. scrolling on bookmarks dialog window

Actual results:

scrolling is very sensitive/unmanageable and skips over lines of bookmark/folder

i am on windows 11 and i have it set to the default to scroll three lines at a time. i have to decrease this to one line or set it to scroll by one screen at a time in order to be able to use the dialog.

Expected results:

scroll should have been more manageable and not skipped over bookmarks/folders in the list.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak] (Away 10-21 August)]

We should try to respect the OS settings if possible.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1957280: Limit user's mouse amount for tree component

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/315b4ea24680
https://hg.mozilla.org/integration/autoland/rev/a839fe6208da
Limit user's mouse amount for tree component r=places-reviewers,reusable-components-reviewers,masayuki,mstriemer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f141d25061c4
https://hg.mozilla.org/integration/autoland/rev/a5d87b01feb5
Revert "Bug 1957280: Limit user's mouse amount for tree component r=places-reviewers,reusable-components-reviewers,masayuki,mstriemer" for causing mochitest-chrome failures on test_tree_scroll.xhtml.

Comment 6

[Iulian Moraru]

Revert for causing mochitest-chrome failures on test_tree_scroll.xhtml.

• Push with failures

• Failure log

• Backout link

[task 2025-07-09T00:18:21.817+00:00] 00:18:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_tree_scroll.xhtml | undefined assertion name 
[task 2025-07-09T00:18:21.817+00:00] 00:18:21     INFO - waiting for mousemove
[task 2025-07-09T00:18:21.818+00:00] 00:18:21     INFO - waiting for wheel
[task 2025-07-09T00:18:21.818+00:00] 00:18:21     INFO - waiting for apz
[task 2025-07-09T00:18:21.819+00:00] 00:18:21     INFO - Buffered messages finished
[task 2025-07-09T00:18:21.819+00:00] 00:18:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_tree_scroll.xhtml | Limit scrolling so that part of the previous result remains - got 2, expected 3
[task 2025-07-09T00:18:21.819+00:00] 00:18:21     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2025-07-09T00:18:21.819+00:00] 00:18:21     INFO - doScrollLimitMouseScrollAmount@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/tree_shared.js:1847:5
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - async*testtag_tree_scroll@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/tree_shared.js:1831:9
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - async*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:922:41
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_tree_scroll.xhtml:1:11
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - callStackHandler@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:285:24
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - EventHandlerNonNull*this.addLoadEvent@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:314:7
[task 2025-07-09T00:18:21.820+00:00] 00:18:21     INFO - @chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1804:15
[task 2025-07-09T00:18:21.821+00:00] 00:18:21     INFO - GECKO(2588) | MEMORY STAT | vsize 1814MB | vsizeMaxContiguous 1293MB | residentFast 603MB | heapAllocated 147MB
[task 2025-07-09T00:18:21.821+00:00] 00:18:21     INFO - GECKO(2588) | [Parent 6612, Main Thread] WARNING: '!root', file /builds/worker/checkouts/gecko/dom/base/Document.cpp:8764
[task 2025-07-09T00:18:21.822+00:00] 00:18:21     INFO - GECKO(2588) | [Parent 6612, Main Thread] WARNING: '!root', file /builds/worker/checkouts/gecko/dom/base/Document.cpp:8764
[task 2025-07-09T00:18:21.823+00:00] 00:18:21     INFO - GECKO(2588) | [Parent 6612, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1215
[task 2025-07-09T00:18:21.824+00:00] 00:18:21     INFO - TEST-OK | toolkit/content/tests/chrome/test_tree_scroll.xhtml | took 21187ms
[task 2025-07-09T00:18:21.824+00:00] 00:18:21     INFO - TEST-START | toolkit/content/tests/chrome/test_tree_single.xhtml

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/44b433258df6
https://hg.mozilla.org/integration/autoland/rev/a5500d271fe3
Limit user's mouse amount for tree component r=places-reviewers,reusable-components-reviewers,masayuki,mstriemer

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a5500d271fe3

Comment 9

[Dianna Smith [:diannaS]]

:daisuke is this something you want to call out in the fx142 release notes? Please nominate if so.

Comment 10

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Dianna!
Oh, it is first time for me. If it can nominate, the note might be like::
Improve mousewheel scroll speed in the bookmarks dialog to not beyond the component area

Comment 11

[Dianna Smith [:diannaS]]

No problem, here is some documentation for next time. Spoiler: you just have to update the relnote flag and fill out the note in the comment section.

Added to 142 relnotes with slightly altered wording

Improved the scroll speed in the bookmarks dialog to not go beyond the component area