195731 - Compiler warning in security/manager/ssl/src/nsPKCS12Blob.cpp

Status: RESOLVED DUPLICATE of bug 194240

(Core Graveyard :: Security: UI, defect)

Description

[tenthumbs]

Gcc says 

  nsPKCS12Blob.cpp:538: warning: \
   comparison of unsigned expression < 0 is always false

The code is

     529   PRUint32 amount;
     ...
     538     if (amount < 0) {
     539       fileStream.close();
     540       return NS_ERROR_FAILURE;
     541     }

so the error block is unreachable and gcc eliminates it.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Over to something like the right product....

Comment 2

[Serge Gautherie (:sgautherie)]

Fix included in bug 194240 attachment 117024 [details] [diff] [review]
{
   while (PR_TRUE) {
-    amount = fileStream.read(buf, PIP_PKCS12_BUFFER_SIZE);
-    if (amount < 0) {
-      fileStream.close();
-      return NS_ERROR_FAILURE;
+    rv = fileStream->Read(buf, PIP_PKCS12_BUFFER_SIZE, &amount);
+    if (NS_FAILED(rv)) {
+      return rv;
     }
}
which was v1.36.

*** This bug has been marked as a duplicate of 194240 ***